From: Dan Carpenter <error27@gmail.com>
To: yang.yang29@zte.com.cn
Cc: larry.finger@lwfinger.net, phil@philpotter.co.uk,
paskripkin@gmail.com, martin@kaiser.cx, abdun.nihaal@gmail.com,
straube.linux@gmail.com, sandsch@northvilleschools.net,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
xu.panda@zte.com.cn
Subject: Re: [PATCH linux-next] staging: r8188eu: use strscpy() to instead of strncpy()
Date: Thu, 29 Dec 2022 12:57:33 +0300 [thread overview]
Message-ID: <Y61kjbim7IDSLSyd@kadam> (raw)
In-Reply-To: <202212261905476729002@zte.com.cn>
On Mon, Dec 26, 2022 at 07:05:47PM +0800, yang.yang29@zte.com.cn wrote:
> From: Xu Panda <xu.panda@zte.com.cn>
>
> The implementation of strscpy() is more robust and safer.
> That's now the recommended way to copy NUL-terminated strings.
>
> Signed-off-by: Xu Panda <xu.panda@zte.com.cn>
> Signed-off-by: Yang Yang <yang.yang29@zte.com>
> ---
Looks good.
Reviewed-by: Dan Carpenter <error27@gmail.com>
regards,
dan carpenter
prev parent reply other threads:[~2022-12-29 10:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-26 11:05 [PATCH linux-next] staging: r8188eu: use strscpy() to instead of strncpy() yang.yang29
2022-12-29 9:57 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y61kjbim7IDSLSyd@kadam \
--to=error27@gmail.com \
--cc=abdun.nihaal@gmail.com \
--cc=larry.finger@lwfinger.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=martin@kaiser.cx \
--cc=paskripkin@gmail.com \
--cc=phil@philpotter.co.uk \
--cc=sandsch@northvilleschools.net \
--cc=straube.linux@gmail.com \
--cc=xu.panda@zte.com.cn \
--cc=yang.yang29@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox