From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B67BC3DA7A for ; Thu, 29 Dec 2022 13:17:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230341AbiL2NRg (ORCPT ); Thu, 29 Dec 2022 08:17:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47852 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229637AbiL2NRe (ORCPT ); Thu, 29 Dec 2022 08:17:34 -0500 Received: from mail-pl1-x62b.google.com (mail-pl1-x62b.google.com [IPv6:2607:f8b0:4864:20::62b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 37697BF6E for ; Thu, 29 Dec 2022 05:17:31 -0800 (PST) Received: by mail-pl1-x62b.google.com with SMTP id 20so5470250plo.3 for ; Thu, 29 Dec 2022 05:17:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=XB/5UP/6Hlg6zTc+Ud2YT+DViPlugAJ2lyEfvvnjKZo=; b=WSaNH1wYnCQ2F4DfK3LHH0f36myjyXNNCEIsNZkta/yfavxOHNCpUlSzOrQwL/vrLV X/5TG/lQ4yV2U/NZDmutVlMglPI8WZDfS4Gi1mZ/M9LK6hv0RbU4+626/qrrOChAdT9N VTL6GoSUVR31hVmRJKTNkusi5IjqZWAMWiwQSD0alNUCNgjboCsFVkjx6BT2yJnG2s9R 39j2EoSFIdbU51W7KWOABz5jar/dogLdycBNuuynrzpdxyPsxIz6BXGOMrg7bdAvXDyy h3o2tvth78JuiWpzmmXGvBVoi2Yteq3/8rKMG9sOJyJf6jOKB7wHnFBGIMsOYaQNiXAd qaCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XB/5UP/6Hlg6zTc+Ud2YT+DViPlugAJ2lyEfvvnjKZo=; b=gARCgGUP46QZkdF9xtAwe9fbg2IupVkKsy2W+sDK243bnDJ0mkox1dGj5QTKfVqx3k O5ABttF7XmAZ+6U1Eto4Roux7EXjYBmAGLIirwKsx2gORAPWLeOBbEzS2+/xkRbWKHRG U4gezZZKH44UMX62MNcQ1TN1nVBW2gq17VS64A51ygytYrjsnWtr41qoiac0dO/jECFc 50NhmigcR01KxW+2wCO7AfItCSbfLQ7ISpErBTqoayb2oZdMYtAcV3/yXC9Hxyeq3m7K QVxkkDSE/zI+DPleLDkfB74Kl/rNBPWMC6geW9hq5XT9J6USqhRpCsUa7f+yxaKcFoHL aEMw== X-Gm-Message-State: AFqh2kq8QF+zZX/aiOHDY3+697RdW10GrlB/vdeGTpDcwmlwIDXk9Th6 8Mk/cVNBoCq6MxHoolAe0nU= X-Google-Smtp-Source: AMrXdXtIST9doYDjZbreinPfq6LLl8u+EjrKg8kUSPl4LiBW+zcgu1u3TK6StxalYI7xvOmgrq9nUw== X-Received: by 2002:a17:902:7601:b0:192:8e8b:bcf with SMTP id k1-20020a170902760100b001928e8b0bcfmr8590295pll.56.1672319850632; Thu, 29 Dec 2022 05:17:30 -0800 (PST) Received: from hyeyoo ([114.29.91.56]) by smtp.gmail.com with ESMTPSA id n6-20020a170902d2c600b0018962933a3esm12945038plc.181.2022.12.29.05.17.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Dec 2022 05:17:29 -0800 (PST) Date: Thu, 29 Dec 2022 22:17:23 +0900 From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: HORIGUCHI =?utf-8?B?TkFPWUEo5aCA5Y+j44CA55u05LmfKQ==?= Cc: Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Roman Gushchin , Joe Perches , Petr Mladek , Andy Shevchenko , Matthew WilCox , David Hildenbrand , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" Subject: Re: [RFC v3 1/4] mm/hwpoison: remove MF_MSG_SLAB from action_page_types Message-ID: References: <20221218101901.373450-1-42.hyeyoo@gmail.com> <20221218101901.373450-2-42.hyeyoo@gmail.com> <20221220235246.GA2334024@hori.linux.bs1.fc.nec.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20221220235246.GA2334024@hori.linux.bs1.fc.nec.co.jp> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 20, 2022 at 11:53:11PM +0000, HORIGUCHI NAOYA(堀口 直也) wrote: > On Sun, Dec 18, 2022 at 07:18:58PM +0900, Hyeonggon Yoo wrote: > > As suggested by Naoya [1], identify_page_state() is never > > called when handling memory error on a slab page. > > > > Clean this up before moving PG_slab flag to page_type in later patch. > > > > [1] https://lore.kernel.org/linux-mm/Y2s+dnBsHAJu19ob@hyeyoo/#r > > > > Suggested-by: Naoya Horiguchi > > Signed-off-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> > > Thank you for the patch, > I think there're a few other places to remove under include/. > > $ grep -inr MF_MSG_SLA include > include/ras/ras_event.h:359: EM ( MF_MSG_SLAB, "kernel slab page" ) \ > include/linux/mm.h:3502: MF_MSG_SLAB, > > , so could you update them together? Oh, missed this. Will do in next version. -- Thanks, Hyeonggon