From: Nicolas Schier <nicolas@fjasle.eu>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>
Subject: Re: [PATCH 2/2] kbuild: add more comments for KBUILD_NOCMDDEP=1
Date: Thu, 29 Dec 2022 15:11:59 +0100 [thread overview]
Message-ID: <Y62gL0J8ZfWE+RjS@fjasle.eu> (raw)
In-Reply-To: <20221229091501.916296-2-masahiroy@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 767 bytes --]
On Thu, Dec 29, 2022 at 06:15:01PM +0900 Masahiro Yamada wrote:
> The cmd-check for KBUILD_NOCMDDEP=1 may not be clear until you see
> commit c4d5ee13984f ("kbuild: make KBUILD_NOCMDDEP=1 handle empty
> built-in.o").
>
> When a phony target (i.e. FORCE) is the only prerequisite, Kbuild
> uses a tricky way to detect that the target does not exist.
>
> Add more comments.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
>
> scripts/Kbuild.include | 6 ++++++
> 1 file changed, 6 insertions(+)
>
Reviewed-by: Nicolas Schier <nicolas@fjasle.eu>
--
epost|xmpp: nicolas@fjasle.eu irc://oftc.net/nsc
↳ gpg: 18ed 52db e34f 860e e9fb c82b 7d97 0932 55a0 ce7f
-- frykten for herren er opphav til kunnskap --
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-12-29 14:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-29 9:15 [PATCH 1/2] kbuild: rename cmd_$@ to savedcmd_$@ in *.cmd files Masahiro Yamada
2022-12-29 9:15 ` [PATCH 2/2] kbuild: add more comments for KBUILD_NOCMDDEP=1 Masahiro Yamada
2022-12-29 14:11 ` Nicolas Schier [this message]
2022-12-29 14:11 ` [PATCH 1/2] kbuild: rename cmd_$@ to savedcmd_$@ in *.cmd files Nicolas Schier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y62gL0J8ZfWE+RjS@fjasle.eu \
--to=nicolas@fjasle.eu \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox