Re: [PATCH 6.0 0000/1066] 6.0.16-rc2 review

Conor Dooley
2022-12-31T00:09:29Z

[-- Attachment #1: Type: text/plain, Size: 1524 bytes --]

Hey Greg,

On Fri, Dec 30, 2022 at 10:49:23AM +0100, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 6.0.16 release.
> There are 1066 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Sun, 01 Jan 2023 09:38:41 +0000.
> Anything received after that time might be too late.

> Paulo Alcantara <pc@cjr.nz>
> cifs: improve symlink handling for smb2+

This patch here appears to fail allmodconfig + LLVM on RISC-V:
../fs/cifs/smb2inode.c:419:4: error: variable 'idata' is uninitialized when used here [-Werror,-Wuninitialized]
idata->symlink_target = kstrdup(cfile->symlink_target, GFP_KERNEL);
^~~~~
../fs/cifs/smb2inode.c:76:35: note: initialize the variable 'idata' to silence this warning
struct cifs_open_info_data *idata;
^
= NULL
1 error generated.

It looks like this was reported as a smatch error on Christmas Day:
https://lore.kernel.org/all/202212250020.fyWQFNzF-lkp@intel.com/

Given the day in question, missing that report seems pretty
understandable :)

I tried to see if this had been reported already against the patches
themselves, rather than Sasha's queue, but given the size of the patchset
I may have missed it. Apologies for the noise if I have.

Thanks,
Conor.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]