From: Eric Biggers <ebiggers@kernel.org>
To: Tudor Ambarus <tudor.ambarus@linaro.org>
Cc: tytso@mit.edu, adilger.kernel@dilger.ca,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
joneslee@google.com,
syzbot+0827b4b52b5ebf65f219@syzkaller.appspotmail.com,
stable@vger.kernel.org
Subject: Re: [PATCH v2] ext4: Fix possible use-after-free in ext4_find_extent
Date: Fri, 30 Dec 2022 12:07:16 -0800 [thread overview]
Message-ID: <Y69E9DMEk+yEFDNQ@sol.localdomain> (raw)
In-Reply-To: <cf1be149-392d-afa0-092a-c3426868f852@linaro.org>
On Fri, Dec 30, 2022 at 01:42:45PM +0200, Tudor Ambarus wrote:
>
> Seems that __ext4_iget() is not called on writes.
It is called when the inode is first accessed. Usually that's when the file is
opened.
So the question is why didn't it validate the inode's extent header, or
alternatively how did the inode's extent header get corrupted afterwards.
> You can find below the sequence of calls that leads to the bug.
A stack trace is not a reproducer. Things must have happened before that point.
- Eric
next prev parent reply other threads:[~2022-12-30 20:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-30 6:29 [PATCH v2] ext4: Fix possible use-after-free in ext4_find_extent Tudor Ambarus
2022-12-30 6:56 ` Eric Biggers
2022-12-30 11:42 ` Tudor Ambarus
2022-12-30 20:07 ` Eric Biggers [this message]
2023-01-02 5:41 ` Tudor Ambarus
2022-12-30 20:22 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y69E9DMEk+yEFDNQ@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=adilger.kernel@dilger.ca \
--cc=joneslee@google.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=syzbot+0827b4b52b5ebf65f219@syzkaller.appspotmail.com \
--cc=tudor.ambarus@linaro.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox