From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D2D5C4332F for ; Mon, 19 Dec 2022 10:17:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231443AbiLSKRz (ORCPT ); Mon, 19 Dec 2022 05:17:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37046 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231698AbiLSKRs (ORCPT ); Mon, 19 Dec 2022 05:17:48 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 052BADF38; Mon, 19 Dec 2022 02:17:39 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 99ECBB80D3B; Mon, 19 Dec 2022 10:17:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 52477C433EF; Mon, 19 Dec 2022 10:17:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1671445057; bh=/QXfGOD3evtcg2IoOafPGrPY6yYtV+gJwWD2uiKF/Xw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=f7G/Jaxqiuq6eW/uhjaNQwDMAFy1oaenCOM1ZU8r+oQmMw6eWzMQJEdkUbbC/Bkki 0mTsMv3UvtUh9RcCqTQmGzyYxcy2SCsQs6FtEFzugXU45CjWFrKFfqoBYIW/pHScOZ caMby89PR6O5IfqB4OpbanUrnksYmjHo2yo+6P/FmGnDzk12V7jiU6nav/LFg7gF75 GszdSyvORD/+GAbVPlhWPT2/eGWvVRDQyu9I3TUJJovUFis8/QvGGTULgbPSVGUDHb baL7VcCFRRACgNTLHpp71xO4wnpfA8/+U9x4ddRaIM8FoeoFgUc2AkHYOnC0gDMQAN p4Tu393o9dPnw== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1p7DDv-0002di-J3; Mon, 19 Dec 2022 11:18:19 +0100 Date: Mon, 19 Dec 2022 11:18:19 +0100 From: Johan Hovold To: "Jason A. Donenfeld" Cc: Johan Hovold , Ard Biesheuvel , linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, Steev Klimaszewski , Bjorn Andersson Subject: Re: [PATCH] efi: random: fix NULL-deref when refreshing seed Message-ID: References: <20221216091514.6298-1-johan+linaro@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 16, 2022 at 12:39:56PM -0700, Jason A. Donenfeld wrote: > On Fri, Dec 16, 2022 at 10:15:14AM +0100, Johan Hovold wrote: > > Do not try to refresh the RNG seed in case the firmware does not support > > setting variables. > > > > This is specifically needed to prevent a NULL-pointer dereference on the > > Lenovo X13s with some firmware revisions. > > > > Fixes: e7b813b32a42 ("efi: random: refresh non-volatile random seed when RNG is initialized") > > Reported-by: Steev Klimaszewski > > Reported-by: Bjorn Andersson > > Signed-off-by: Johan Hovold > > --- > > Thanks very much for this, and sorry for the breakage. I'll try to get > this in before rc1 is cut, as I've got some other changes scheduled for > late in the merge window to send anyway. In case this one hasn't been picked up yet (it's not in linux-next), I just sent a v2 with an amended commit message with an explicit mention that as this is needed whenever the runtime services have been disabled (e.g. with PREEMPT_RT): https://lore.kernel.org/lkml/20221219101237.9872-1-johan+linaro@kernel.org/ Johan