From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 451E2C4332F for ; Mon, 19 Dec 2022 14:39:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232238AbiLSOi5 (ORCPT ); Mon, 19 Dec 2022 09:38:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42778 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231754AbiLSOiw (ORCPT ); Mon, 19 Dec 2022 09:38:52 -0500 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A56BFFD; Mon, 19 Dec 2022 06:38:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1671460731; x=1702996731; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=aYzZBOs+BOeZN2LyM0VkyKujjc0n0nPt0i+E9p/iOYE=; b=iLc+0NLaeewpWrnpv/HD7lCg+e+iNzy4TtscZjFg3Rer/kkS+yu4t6jx 86uAS6h+uOxc8IGisFRY7+mkq2D1onQqbffCWPzyIIY8nB/OEYNnE/3Z+ wkh7iT01c2NCB5e4glFsLacLvCN1zIzCBI1hbzE/3DBiVohtXs1bYbiLX M1WaTUYUDUfSVN9TEQdYkHXS8bCNDotIvG+YOgPKVkyddBEep/azay/Ym T0wupiR+vAENWis/1t/8f30C9vVs8S2Lbd7oVSxoIC9xLSDcf72hS9n8m p+U1+EfunmI02blwSxmwRAg1bZJmjAyg9U8pdrbC7Q77zvO6Pv7y1M22+ A==; X-IronPort-AV: E=McAfee;i="6500,9779,10566"; a="299038410" X-IronPort-AV: E=Sophos;i="5.96,255,1665471600"; d="scan'208";a="299038410" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Dec 2022 06:38:51 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10566"; a="757642269" X-IronPort-AV: E=Sophos;i="5.96,255,1665471600"; d="scan'208";a="757642269" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga002.fm.intel.com with ESMTP; 19 Dec 2022 06:38:50 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1p7HI0-00CKJs-25; Mon, 19 Dec 2022 16:38:48 +0200 Date: Mon, 19 Dec 2022 16:38:48 +0200 From: Andy Shevchenko To: Mika Westerberg Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Linus Walleij Subject: Re: [PATCH v1 01/17] pinctrl: intel: Introduce INTEL_COMMUNITY_*() to unify community macros Message-ID: References: <20221219122643.3513-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 19, 2022 at 04:32:55PM +0200, Mika Westerberg wrote: > On Mon, Dec 19, 2022 at 02:26:27PM +0200, Andy Shevchenko wrote: > > Now it becomes visible that we can deduplicate SoC specific > > *_COMMUNITY() macros across the Intel pin control drivers. > > For that, introduce a common INTEL_COMMUNITY_GPPS() and > > INTEL_COMMUNITY_SIZE() macros in the pinctrl-intel.h. > > You should really start learning how to use --cover-letter option with > git format-patch because for anything more than one patch pretty much > requires such. Oh, indeed. > Here I would really like to see how much lines this > series ends up removing :) drivers/pinctrl/intel/pinctrl-alderlake.c | 18 ++---------------- drivers/pinctrl/intel/pinctrl-broxton.c | 31 +++++++++++-------------------- drivers/pinctrl/intel/pinctrl-cannonlake.c | 31 +++++++++++-------------------- drivers/pinctrl/intel/pinctrl-cedarfork.c | 13 +------------ drivers/pinctrl/intel/pinctrl-denverton.c | 13 +------------ drivers/pinctrl/intel/pinctrl-elkhartlake.c | 24 +++++++----------------- drivers/pinctrl/intel/pinctrl-emmitsburg.c | 13 +------------ drivers/pinctrl/intel/pinctrl-geminilake.c | 21 ++++++--------------- drivers/pinctrl/intel/pinctrl-icelake.c | 35 +++++++++++++---------------------- drivers/pinctrl/intel/pinctrl-intel.c | 9 +-------- drivers/pinctrl/intel/pinctrl-intel.h | 35 +++++++++++++++++++++++++++++------ drivers/pinctrl/intel/pinctrl-jasperlake.c | 13 +------------ drivers/pinctrl/intel/pinctrl-lakefield.c | 13 +------------ drivers/pinctrl/intel/pinctrl-lewisburg.c | 12 +----------- drivers/pinctrl/intel/pinctrl-meteorlake.c | 23 ++++++----------------- drivers/pinctrl/intel/pinctrl-sunrisepoint.c | 37 +++++++++++++------------------------ drivers/pinctrl/intel/pinctrl-tigerlake.c | 30 ++++++++++-------------------- 17 files changed, 115 insertions(+), 256 deletions(-) > The series looks good to me, though. Thank you! -- With Best Regards, Andy Shevchenko