From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6B4EC4332F for ; Mon, 19 Dec 2022 12:17:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231508AbiLSMRK (ORCPT ); Mon, 19 Dec 2022 07:17:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33060 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230403AbiLSMRH (ORCPT ); Mon, 19 Dec 2022 07:17:07 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 43EC7E4B; Mon, 19 Dec 2022 04:17:06 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D19D260F30; Mon, 19 Dec 2022 12:17:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B6615C433EF; Mon, 19 Dec 2022 12:17:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1671452225; bh=M454FZy6i6tC3jkfuZrZnI4+MIoHRKwIkb5aPX5khWQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=TJP867Y3xXJhBJry1TujzcTTETk5tVlpgsMLyk+lPa7t15vG0KPLZFuUPWSVThkXS m8Vmyka1mdWx/llSH6jGqgxRQy87YTqP5cHyl42MKhsDAtZ+smq8XottR7Ya+gMenh YQKyz0rDbnk8svL6udkEtH8vXL1pByQ17V0JgI50= Date: Mon, 19 Dec 2022 13:17:02 +0100 From: Greg KH To: Marc Zyngier Cc: Sean Anderson , linux-kernel@vger.kernel.org, stable@vger.kernel.org, tglx@linutronix.de Subject: Re: [irqchip: irq/irqchip-next] irqchip/ls-extirq: Fix endianness detection Message-ID: References: <20221201212807.616191-1-sean.anderson@seco.com> <167023926482.4906.17012979311813913704.tip-bot2@tip-bot2> <8e8bfa5e-f713-4590-95db-66ed6454881b@seco.com> <9a7ef68d94e7d0ca879b9f55f7634df5@kernel.org> <3c8c4cf8-9987-31d6-a19c-c18d9f41c7c1@seco.com> <1fd422cf6f379e03949362721ad623f2@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1fd422cf6f379e03949362721ad623f2@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 16, 2022 at 07:23:36PM +0000, Marc Zyngier wrote: > On 2022-12-16 19:11, Sean Anderson wrote: > > On 12/16/22 13:22, Marc Zyngier wrote: > > > On 2022-12-16 16:37, Sean Anderson wrote: > > > > Hi Stable maintainers, > > > > > > > > On 12/5/22 06:21, irqchip-bot for Sean Anderson wrote: > > > > > The following commit has been merged into the > > > > > irq/irqchip-next branch of irqchip: > > > > > > > > > > Commit-ID:     3ae977d0e4e3a2a2ccc912ca2d20c9430508ecdd > > > > > Gitweb:        https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/3ae977d0e4e3a2a2ccc912ca2d20c9430508ecdd > > > > > Author:        Sean Anderson > > > > > AuthorDate:    Thu, 01 Dec 2022 16:28:07 -05:00 > > > > > Committer:     Marc Zyngier > > > > > CommitterDate: Mon, 05 Dec 2022 10:39:52 > > > > > > > > > > irqchip/ls-extirq: Fix endianness detection > > > > > > > > > > parent is the interrupt parent, not the parent of node. Use > > > > > node->parent. This fixes endianness detection on big-endian > > > > > platforms. > > > > > > > > > > Fixes: 1b00adce8afd ("irqchip/ls-extirq: Fix invalid wait > > > > > context by avoiding to use regmap") > > > > > Signed-off-by: Sean Anderson > > > > > Signed-off-by: Marc Zyngier > > > > > Link: https://lore.kernel.org/r/20221201212807.616191-1-sean.anderson@seco.com > > > > > --- > > > > >  drivers/irqchip/irq-ls-extirq.c | 2 +- > > > > >  1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > > > diff --git a/drivers/irqchip/irq-ls-extirq.c > > > > > b/drivers/irqchip/irq-ls-extirq.c > > > > > index d8d48b1..139f26b 100644 > > > > > --- a/drivers/irqchip/irq-ls-extirq.c > > > > > +++ b/drivers/irqchip/irq-ls-extirq.c > > > > > @@ -203,7 +203,7 @@ ls_extirq_of_init(struct device_node > > > > > *node, struct device_node *parent) > > > > >         if (ret) > > > > >                 goto err_parse_map; > > > > > > > > > > -       priv->big_endian = of_device_is_big_endian(parent); > > > > > +       priv->big_endian = of_device_is_big_endian(node->parent); > > > > >         priv->is_ls1021a_or_ls1043a = > > > > > of_device_is_compatible(node, "fsl,ls1021a-extirq") || > > > > >                                       > > > > > of_device_is_compatible(node, "fsl,ls1043a-extirq"); > > > > >         raw_spin_lock_init(&priv->lock); > > > > > > > > This patch has made it into linux/master, but it should also get > > > > backported to 6.1. Just want to make sure this doesn't fall > > > > through the > > > > cracks, since this was a really annoying bug to deal with > > > > (causes an IRQ > > > > storm). > > > > > > If you wanted it backported, why didn't it have a Cc: stable > > > the first place? In any case, if you want a backport to happen, > > > you'll have to post that backport. > > > > Usually, anything with a Fixes: tag gets picked up. That is NEVER guaranteed at all, please use the system we have had for the past 18+ years and properly tag patches with "cc: stable" that you want applied to a stable tree. > > Actually, I was > > expecting you to submit a PR for 6.1, since this was submitted before > > that release came out. > > Expectations are better stated rather than being implicit. > > > That said, this email is "option 2" of > > Documentation/process/stable-kernel-rules.rst, so I don't think I need > > to do "option 3". > > Here's to hope! I queued it up now, thanks. greg k-h