Re: [PATCH] mm: vmalloc: correct use of __GFP_NOWARN mask in __vmalloc_area_node()

Lorenzo Stoakes
2022-12-19T12:25:55Z

On Mon, Dec 19, 2022 at 01:09:41PM +0100, Uladzislau Rezki wrote:
> There are three more warn_alloc()s below. Those are explicitly disabled.
> Could you please rework the patch and make it working also?

Ah yes, sorry missed those, I think then the simplest solution then would be to
simply yank the __GFP_NOWARN specifier at the top of the function and restore
the explicit flag being passed to vm_area_alloc_pages() you added in
c3d77172dfc0.

This whole thing does make me wonder if this function is due a more general
refactor.

Will spin up a v2!