From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Johan Hovold <johan+linaro@kernel.org>
Cc: Ard Biesheuvel <ardb@kernel.org>,
linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org,
Steev Klimaszewski <steev@kali.org>,
Bjorn Andersson <andersson@kernel.org>,
Andrew Halaney <ahalaney@redhat.com>
Subject: Re: [PATCH v2] efi: random: fix NULL-deref when refreshing seed
Date: Mon, 19 Dec 2022 15:00:17 +0100 [thread overview]
Message-ID: <Y6Bucfoykf2lMdQQ@zx2c4.com> (raw)
In-Reply-To: <20221219101237.9872-1-johan+linaro@kernel.org>
On Mon, Dec 19, 2022 at 11:12:37AM +0100, Johan Hovold wrote:
> Do not try to refresh the RNG seed in case the firmware does not support
> setting variables.
>
> This is specifically needed to prevent a NULL-pointer dereference on the
> Lenovo X13s with some firmware revisions, or more generally, whenever
> the runtime services have been disabled (e.g. efi=noruntime or with
> PREEMPT_RT).
>
> Fixes: e7b813b32a42 ("efi: random: refresh non-volatile random seed when RNG is initialized")
> Reported-by: Steev Klimaszewski <steev@kali.org>
> Reported-by: Bjorn Andersson <andersson@kernel.org>
> Tested-by: Andrew Halaney <ahalaney@redhat.com> # sc8280xp-lenovo-thinkpad-x13s
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> ---
>
> Changes in v2
> - amend commit message with a comment on this being needed whenever the
> runtime services have been disabled
I'll queue up the one with the amended commit message.
Jason
next prev parent reply other threads:[~2022-12-19 14:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-19 10:12 [PATCH v2] efi: random: fix NULL-deref when refreshing seed Johan Hovold
2022-12-19 14:00 ` Jason A. Donenfeld [this message]
2022-12-19 14:08 ` Johan Hovold
2022-12-19 14:40 ` Steev Klimaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y6Bucfoykf2lMdQQ@zx2c4.com \
--to=jason@zx2c4.com \
--cc=ahalaney@redhat.com \
--cc=andersson@kernel.org \
--cc=ardb@kernel.org \
--cc=johan+linaro@kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=steev@kali.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox