From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 26948C4332F
	for <linux-kernel@archiver.kernel.org>; Thu, 22 Dec 2022 05:55:13 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S234980AbiLVFzM (ORCPT <rfc822;linux-kernel@archiver.kernel.org>);
        Thu, 22 Dec 2022 00:55:12 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44578 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S229601AbiLVFzH (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 22 Dec 2022 00:55:07 -0500
Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1EADE99;
        Wed, 21 Dec 2022 21:55:06 -0800 (PST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by dfw.source.kernel.org (Postfix) with ESMTPS id B05A6619B6;
        Thu, 22 Dec 2022 05:55:05 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 57001C433EF;
        Thu, 22 Dec 2022 05:55:04 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org;
        s=korg; t=1671688505;
        bh=TRscKl5gR6cr50JxhDtAZyUtxqv9kZrOWAk32Jm8tDk=;
        h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
        b=cb5/JgXj7bheGLLuH7nYeDxU1yxbN/nfWGvuc2ljVOikHK8ZQOJ20sBlNeVjvb5mv
         3a3gNDbR6XnTU631XArBepSMV2mHUgK7gSVn9QplTf1ubkXB0fpZLh33srIW4jSG4o
         eUZhY3wGxLmC1Pc744bZD2yybA1bhho/afoamfWM=
Date:   Thu, 22 Dec 2022 06:55:01 +0100
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     Deepak R Varma <drv@mailo.com>
Cc:     "Maciej W. Rozycki" <macro@orcam.me.uk>,
        Jiri Slaby <jirislaby@kernel.org>,
        linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
        Saurabh Singh Sengar <ssengar@microsoft.com>,
        Praveen Kumar <kumarpraveen@linux.microsoft.com>
Subject: Re: [PATCH] tty: serial: convert atomic_* to refcount_* APIs
Message-ID: <Y6PxNRgzPAdukDs5@kroah.com>
References: <Y6NlNB9c22XiYHdD@qemulion>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Y6NlNB9c22XiYHdD@qemulion>
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Dec 22, 2022 at 01:27:40AM +0530, Deepak R Varma wrote:
> The refcount_* APIs are designed to address known issues with the
> atomic_t APIs for reference counting. They protect the reference
> counters from overflow/underflow, use-after-free errors, provide
> improved memory ordering guarantee schemes, are neater and safer.
> Hence, replace the atomic_* APIs by their equivalent refcount_t
> API functions.
> 
> This patch proposal address the following warnings generated by
> the atomic_as_refcounter.cocci coccinelle script
> 	atomic_add_return(-1, ...)
> 
> 
> Signed-off-by: Deepak R Varma <drv@mailo.com>
> ---
> Note: The patch is compile tested using dec_station.defconfig for
>       MIPS architecture.

Do you have this hardware?  If not, please just do
one-variable-at-a-time so that if there are real problems, we can revert
the offending change easier.  And it makes it simpler to review.

But, are you sure this is correct:

> -	irq_guard = atomic_add_return(1, &mux->irq_guard);
> -	if (irq_guard != 1)
> +	refcount_inc(&mux->irq_guard);
> +	if (refcount_read(&mux->irq_guard) != 1)

That is now different logic than before, why?  Are you sure this is ok?

I stopped reviewing here...

thanks,

greg k-h