Re: [PATCH v9 1/4] crypto: ccp - Name -1 return value as SEV_RET_NO_FW_CALL

Tom Lendacky
2022-12-26T14:29:30Z

On 12/22/22 09:31, Borislav Petkov wrote:
> On Wed, Dec 07, 2022 at 01:02:07AM +0000, Dionna Glaze wrote:
>> From: Peter Gonda <pgonda@google.com>
>>
>> The PSP can return a "firmware error" code of -1 in circumstances where
>> the PSP is not actually called. To make this protocol unambiguous, the
>> value is named SEV_RET_NO_FW_CALL.
>>
>> Cc: Thomas Lendacky <Thomas.Lendacky@amd.com>
>> Cc: Paolo Bonzini <pbonzini@redhat.com>
>> Cc: Joerg Roedel <jroedel@suse.de>
>> Cc: Ingo Molnar <mingo@redhat.com>
>> Cc: Andy Lutomirsky <luto@kernel.org>
>> Cc: John Allen <john.allen@amd.com>
>> Cc: Herbert Xu <herbert@gondor.apana.org.au>
>> Cc: "David S. Miller" <davem@davemloft.net>
>> Cc: Borislav Petkov <bp@alien8.de>
>>
>> Signed-off-by: Peter Gonda <pgonda@google.com>
>> Signed-off-by: Dionna Glaze <dionnaglaze@google.com>
>> ---
>> Documentation/virt/coco/sev-guest.rst | 2 +-
>> drivers/crypto/ccp/sev-dev.c | 22 ++++++++++++++--------
>> include/uapi/linux/psp-sev.h | 7 +++++++
>> 3 files changed, 22 insertions(+), 9 deletions(-)
>
> Looks good, did some minor touch ups ontop, see below.
>
> @Tom: Ack/Rev-by?

Acked-by: Tom Lendacky <thomas.lendacky@amd.com>

>
> @Herbert: ok to carry this through tip?
>
> Thx.
>