From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 325B8C001B2 for ; Thu, 22 Dec 2022 20:31:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229863AbiLVUbA (ORCPT ); Thu, 22 Dec 2022 15:31:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52276 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229583AbiLVUa6 (ORCPT ); Thu, 22 Dec 2022 15:30:58 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 85270101CE; Thu, 22 Dec 2022 12:30:56 -0800 (PST) Received: from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi [213.243.189.158]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 54CF3471; Thu, 22 Dec 2022 21:30:52 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1671741052; bh=+1jkARAbTLLjLgzzWLH5WqP65CFDkpPXBUpu0s8gVDM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=D+IuuP+uoj0/dvs3mNCGmKnxDEXKxLnS0YEjNJ21Mqtqq6QKzpgViEEMo3Z04rtt0 PkeuUOEOX56quXb0jEBcshXwyy3o1JX6l9m+Fu3Sw9gDx4f723VI4PDHKnREbvO/hV sKnaT1kvpBrHfe550vSjHRhP/ZXFaUWmAqR+a5kc= Date: Thu, 22 Dec 2022 22:30:47 +0200 From: Laurent Pinchart To: Umang Jain Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Greg Kroah-Hartman , Adrien Thierry , Stefan Wahren , Florian Fainelli , Dan Carpenter , Nicolas Saenz Julienne , Phil Elwell , Dave Stevenson , Kieran Bingham Subject: Re: [PATCH v2 1/4] staging: vc04_services: Stop leaking platform device on error path Message-ID: References: <20221222191500.515795-1-umang.jain@ideasonboard.com> <20221222191500.515795-2-umang.jain@ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20221222191500.515795-2-umang.jain@ideasonboard.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Umang, Thank you for the patch. On Fri, Dec 23, 2022 at 12:44:57AM +0530, Umang Jain wrote: > vchiq driver registers the child platform devices in > vchiq_register_child(). However, in the registration error code path, > currently the driver is leaking platform devices by not destroying the > return platform device. Plug this leak using platform_device_put() as > mentioned in the documentation for platform_device_register(). > > Signed-off-by: Umang Jain > --- > drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c > index dc33490ba7fb..fc7ea7ba97b2 100644 > --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c > +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c > @@ -1779,6 +1779,7 @@ vchiq_register_child(struct platform_device *pdev, const char *name) > child = platform_device_register_full(&pdevinfo); > if (IS_ERR(child)) { > dev_warn(&pdev->dev, "%s not registered\n", name); > + platform_device_put(child); If IS_ERR(child), what do you expect platform_device_put(child) to do ? And have you read the implementation of platform_device_register_full() ? > child = NULL; > } > -- Regards, Laurent Pinchart