From: 'Greg Kroah-Hartman' <gregkh@linuxfoundation.org>
To: Prashanth K <quic_prashk@quicinc.com>
Cc: David Laight <David.Laight@aculab.com>,
Dan Carpenter <error27@gmail.com>,
"Gustavo A . R . Silva" <gustavoars@kernel.org>,
Shuah Khan <skhan@linuxfoundation.org>,
John Keeping <john@metanate.com>,
Pratham Pratap <quic_ppratap@quicinc.com>,
Vincent Pelletier <plr.vincent@gmail.com>,
Udipto Goswami <quic_ugoswami@quicinc.com>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"# 5 . 15" <stable@vger.kernel.org>
Subject: Re: usb: f_fs: Fix CFI failure in ki_complete
Date: Fri, 23 Dec 2022 15:51:07 +0100 [thread overview]
Message-ID: <Y6XAW8JrwjQ4DkJV@kroah.com> (raw)
In-Reply-To: <acdda510-945f-ff68-5c8b-a1a0290bed6d@quicinc.com>
On Thu, Dec 22, 2022 at 06:21:03PM +0530, Prashanth K wrote:
>
>
> On 14-12-22 11:05 pm, David Laight wrote:
> > From: Greg Kroah-Hartman
> > > Sent: 12 December 2022 13:35
> > >
> > > On Mon, Dec 12, 2022 at 06:54:24PM +0530, Prashanth K wrote:
> > > > Function pointer ki_complete() expects 'long' as its second
> > > > argument, but we pass integer from ffs_user_copy_worker. This
> > > > might cause a CFI failure, as ki_complete is an indirect call
> > > > with mismatched prototype. Fix this by typecasting the second
> > > > argument to long.
> > >
> > > "might"? Does it or not? If it does, why hasn't this been reported
> > > before?
> >
> > Does the cast even help at all.
> Actually I also have these same questions
> - why we haven't seen any instances other than this one?
> - why its not seen on other indirect function calls?
Great, please work on figuring these out before you resubmit this again
as obviously we can't take this change without knowing the answers here.
good luck!
greg k-h
next prev parent reply other threads:[~2022-12-23 14:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-12 13:24 usb: f_fs: Fix CFI failure in ki_complete Prashanth K
2022-12-12 13:35 ` Greg Kroah-Hartman
2022-12-14 13:08 ` Prashanth K
2022-12-14 14:56 ` Greg Kroah-Hartman
2022-12-14 17:35 ` David Laight
2022-12-22 12:51 ` Prashanth K
2022-12-23 9:04 ` Dan Carpenter
2022-12-23 14:41 ` Alexander Lobakin
2022-12-23 14:51 ` 'Greg Kroah-Hartman' [this message]
2022-12-12 13:37 ` John Keeping
2022-12-12 13:49 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y6XAW8JrwjQ4DkJV@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=David.Laight@aculab.com \
--cc=error27@gmail.com \
--cc=gustavoars@kernel.org \
--cc=john@metanate.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=plr.vincent@gmail.com \
--cc=quic_ppratap@quicinc.com \
--cc=quic_prashk@quicinc.com \
--cc=quic_ugoswami@quicinc.com \
--cc=skhan@linuxfoundation.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox