From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 9E4F7C4332F
	for <linux-kernel@archiver.kernel.org>; Fri, 23 Dec 2022 16:29:09 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S236240AbiLWQ3H (ORCPT <rfc822;linux-kernel@archiver.kernel.org>);
        Fri, 23 Dec 2022 11:29:07 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44960 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S236010AbiLWQ3B (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 23 Dec 2022 11:29:01 -0500
Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6B37A220EB
        for <linux-kernel@vger.kernel.org>; Fri, 23 Dec 2022 08:28:59 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
        d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version
        :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:
        Content-Transfer-Encoding:Content-ID:Content-Description;
        bh=l8Xt/3atswUT69U09UNdnUFdOKiDOqd4GvHj/Wr9dKo=; b=SeixTs5FTyePf9lvHU0rAXjXcf
        HlW7R06P3fVJ+Ev1gg0H9Id9Zn/eg6YeF8ZYrpX0JlyLCpibAEspHqg52k+R98fZlxd7tXMWzKrRL
        ZuPu4H42QxC/YUVoAVGsF8msM2JnoloeGNWRx7ZDpXCUHWIOcwpxBmbkJ5C2Oepl18uBztjtRas1C
        WxOM9vcf4dPALYEfZSEoB/6nZ1EFRBOEiknYk2dX82HRaV1CjaQjoEgspAbWPtJTLJctbfYamKtnF
        vilnH2l3f+akVkPa7aTeA6Jn0GKxcOhKtN1kz/fldUQ35PB52KFgdqWPNTXHacsnbFneRgKRBXLUB
        chcgcdDw==;
Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux))
        id 1p8kum-009z7Z-Cx; Fri, 23 Dec 2022 16:28:56 +0000
Date:   Fri, 23 Dec 2022 08:28:56 -0800
From:   Christoph Hellwig <hch@infradead.org>
To:     Keith Busch <kbusch@meta.com>
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        Matthew Wilcox <willy@infradead.org>,
        Tony Battersby <tonyb@cybernetics.com>,
        Kernel Team <kernel-team@meta.com>,
        Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCHv2 03/11] dmapool: use sysfs_emit() instead of scnprintf()
Message-ID: <Y6XXSDuqCC9EoxI6@infradead.org>
References: <20221216201625.2362737-1-kbusch@meta.com>
 <20221216201625.2362737-4-kbusch@meta.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221216201625.2362737-4-kbusch@meta.com>
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> +		size += sysfs_emit_at(buf, size, "%-16s %4u %4zu %4zu %2u\n",
> +				      pool->name, blocks,
> +				      pages * (pool->allocation / pool->size),
> +				      pool->size, pages);

Did I mention that the sysfs_emit_at API sucks and should just take
size as a pointer argument an auto-increment?

Not really something we can change in this series, though.  So:

Reviewed-by: Christoph Hellwig <hch@lst.de>