From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3BC2C4332F for ; Tue, 27 Dec 2022 13:04:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231563AbiL0NES (ORCPT ); Tue, 27 Dec 2022 08:04:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49210 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229789AbiL0NEP (ORCPT ); Tue, 27 Dec 2022 08:04:15 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 39A326546; Tue, 27 Dec 2022 05:04:15 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id DA878B81018; Tue, 27 Dec 2022 13:04:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 595F4C433EF; Tue, 27 Dec 2022 13:04:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1672146252; bh=h42tCSHbnqvK8vlzC0z3qtjM8IKb2Ml+g4s3G+u8YAw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Dihhn9rmIYrL0+fz9PYVoqH8FhEtLjiGKNFcDZjl+CAIeheBvYw+HgbJjyfe2ah2u QJt0oV8gCrU5R6VxFoCHz8UAMkPCUzK6VkPd9Wr75mSiCGoQChaUgtnpxTwVtzL5wT FhccscTdZe9bQQ6nvM5S9X+PvSzbSeRGd6MHYXGhJvNMKYvHJK/IwAypXDn20DjfvZ 2eE5dkSS4lUMIFg7WEt9tHUCtrhDXkJrygvW9g+Gvv4H4rmmpZugyHVAQvcfrhNC38 9G3VSPfe8BUv1a5LngOWcsjejZKupXdb/U1p3F4gOAyiAWUDLh2ezv5hZBFbZpiI7/ xMlehFZAbyohw== Date: Tue, 27 Dec 2022 08:04:11 -0500 From: Sasha Levin To: Johan Hovold Cc: stable-commits@vger.kernel.org, johan+linaro@kernel.org, Andy Gross , Bjorn Andersson , Konrad Dybcio , Kishon Vijay Abraham I , Vinod Koul , linux-kernel@vger.kernel.org Subject: Re: Patch "phy: qcom-qmp-combo: fix runtime suspend" has been added to the 5.15-stable tree Message-ID: References: <20221225150913.691403-1-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 27, 2022 at 10:14:59AM +0100, Johan Hovold wrote: >On Sun, Dec 25, 2022 at 10:09:13AM -0500, Sasha Levin wrote: >> This is a note to let you know that I've just added the patch titled >> >> phy: qcom-qmp-combo: fix runtime suspend >> >> to the 5.15-stable tree which can be found at: >> http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary >> >> The filename of the patch is: >> phy-qcom-qmp-combo-fix-runtime-suspend.patch >> and it can be found in the queue-5.15 subdirectory. >> >> If you, or anyone else, feels it should not be added to the stable tree, >> please let know about it. >> >> >> >> commit d17b3a7b0119f7d92788acbe0f3d3b31bd8f892b >> Author: Johan Hovold >> Date: Mon Nov 14 09:13:45 2022 +0100 >> >> phy: qcom-qmp-combo: fix runtime suspend >> >> [ Upstream commit c7b98de745cffdceefc077ad5cf9cda032ef8959 ] >> >> Drop the confused runtime-suspend type check which effectively broke >> runtime PM if the DP child node happens to be parsed before the USB >> child node during probe (e.g. due to order of child nodes in the >> devicetree). >> >> Instead use the new driver data USB PHY pointer to access the USB >> configuration and resources. >> >> Fixes: 52e013d0bffa ("phy: qcom-qmp: Add support for DP in USB3+DP combo phy") >> Reviewed-by: Dmitry Baryshkov >> Signed-off-by: Johan Hovold >> Link: https://lore.kernel.org/r/20221114081346.5116-6-johan+linaro@kernel.org >> Signed-off-by: Vinod Koul >> Signed-off-by: Sasha Levin > >This one was not marked for stable and can not be backported without >further dependencies. This driver did not even exist in 5.15, and no, >you should no try to backport the split of the original driver either. I'll drop this patch. >Sasha, please stop this madness. So help me understand this... The fixes tag says: Fixes: 52e013d0bffa ("phy: qcom-qmp: Add support for DP in USB3+DP combo phy") 52e013d0bffa was merged in v5.10. Does the tag point to the wrong commit? -- Thanks, Sasha