From: Vinod Koul <vkoul@kernel.org>
To: Mohan Kumar <mkumard@nvidia.com>
Cc: ldewangan@nvidia.com, jonathanh@nvidia.com,
thierry.reding@gmail.com, dmaengine@vger.kernel.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
stable-commits@vger.kernel.org
Subject: Re: [PATCH] dmaengine: tegra210-adma: fix global intr clear
Date: Wed, 28 Dec 2022 11:44:48 +0530 [thread overview]
Message-ID: <Y6ve2MUrG+/DtjbG@matsya> (raw)
In-Reply-To: <20221226065153.5558-1-mkumard@nvidia.com>
On 26-12-22, 12:21, Mohan Kumar wrote:
> The current global interrupt clear programming register offset
> was not correct. Fix the programming with right offset
>
> fixes: 'commit ded1f3db4cd6
> ("dmaengine: tegra210-adma: prepare for supporting newer Tegra chips")'
Ugh, this is not the format for fixes tag, see Documentation/process/5.Posting.rst
>
> Signed-off-by: Mohan Kumar <mkumard@nvidia.com>
Why did you CC stable for this email? Again read the process!
> ---
> drivers/dma/tegra210-adma.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/dma/tegra210-adma.c b/drivers/dma/tegra210-adma.c
> index ae39b52012b2..487f8fb411b5 100644
> --- a/drivers/dma/tegra210-adma.c
> +++ b/drivers/dma/tegra210-adma.c
> @@ -221,7 +221,9 @@ static int tegra_adma_init(struct tegra_adma *tdma)
> int ret;
>
> /* Clear any interrupts */
> - tdma_write(tdma, tdma->cdata->global_int_clear, 0x1);
> + tdma_write(tdma,
> + tdma->cdata->ch_base_offset + tdma->cdata->global_int_clear,
> + 0x1);
This looks _very_ ugly, one line should look and read better:
tdma_write(tdma, tdma->cdata->ch_base_offset + tdma->cdata->global_int_clear, 0x1);
We are no longer 80 char limited!
--
~Vinod
next prev parent reply other threads:[~2022-12-28 6:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-26 6:51 [PATCH] dmaengine: tegra210-adma: fix global intr clear Mohan Kumar
2022-12-28 6:14 ` Vinod Koul [this message]
2023-01-02 5:51 ` Mohan Kumar D
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y6ve2MUrG+/DtjbG@matsya \
--to=vkoul@kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mkumard@nvidia.com \
--cc=stable-commits@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox