From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Arnd Bergmann <arnd@arndb.de>, Miaoqian Lin <linmq006@gmail.com>,
Marc Zyngier <maz@kernel.org>,
Lukas Bulwahn <lukas.bulwahn@gmail.com>,
linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pinctrl: nomadik: include linux/seq_file.h
Date: Wed, 28 Dec 2022 10:52:59 +0200 [thread overview]
Message-ID: <Y6wD67Rj4ZCcHQ2X@smile.fi.intel.com> (raw)
In-Reply-To: <Y5tWhi9s5fGDMfxW@smile.fi.intel.com>
On Thu, Dec 15, 2022 at 07:16:54PM +0200, Andy Shevchenko wrote:
> On Thu, Dec 15, 2022 at 06:00:57PM +0100, Arnd Bergmann wrote:
> > From: Arnd Bergmann <arnd@arndb.de>
> >
> > In some randconfig builds, the missing #include causes a
> > build failure:
> >
> > drivers/pinctrl/nomadik/pinctrl-nomadik.c: In function 'nmk_gpio_irq_print_chip':
> > drivers/pinctrl/nomadik/pinctrl-nomadik.c:1084:9: error: implicit declaration of function 'seq_printf'; did you mean 'bstr_printf'? [-Werror=implicit-function-declaration]
> > 1084 | seq_printf(p, "nmk%u-%u-%u", nmk_chip->bank,
> > | ^~~~~~~~~~
> > | bstr_printf
>
> Hmm... Strange that I have not noticed this from CIs.
> Nevertheless, I have a patch that adds more missing
> headers to this driver. I have planned to send it
> after v6.2-rc1.
>
> I'm fine if this goes first. Up to Linus.
FYI: I have just sent my version
https://lore.kernel.org/r/20221228084310.85210-1-andriy.shevchenko@linux.intel.com
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2022-12-28 8:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-15 17:00 [PATCH] pinctrl: nomadik: include linux/seq_file.h Arnd Bergmann
2022-12-15 17:16 ` Andy Shevchenko
2022-12-28 8:52 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y6wD67Rj4ZCcHQ2X@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=linmq006@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=maz@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox