From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc: linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-hwmon@vger.kernel.org,
Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH v1 1/5] rtc: isl12022: Get rid of unneeded private struct isl12022
Date: Wed, 28 Dec 2022 11:42:22 +0200 [thread overview]
Message-ID: <Y6wPfnRC3YeFxs3S@smile.fi.intel.com> (raw)
In-Reply-To: <a004a051-2f63-b5a4-bf7b-925850f1f718@rasmusvillemoes.dk>
On Tue, Nov 29, 2022 at 03:10:00PM +0100, Rasmus Villemoes wrote:
> On 26/11/2022 15.18, Andy Shevchenko wrote:
> > First of all, the struct rtc_device pointer is kept in the managed
> > resources, no need to keep it outside (no users in the driver).
> >
> > Second, replace private struct isl12022 with a regmap.
>
> Nice simplification.
>
> Acked-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Thank you!
Alexandre, do you have any comments on this series?
If no, can it be applied now?
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2022-12-28 9:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-26 14:18 [PATCH v1 1/5] rtc: isl12022: Get rid of unneeded private struct isl12022 Andy Shevchenko
2022-11-26 14:18 ` [PATCH v1 2/5] rtc: isl12022: Explicitly use __le16 type for ISL12022_REG_TEMP_L Andy Shevchenko
2022-11-29 14:13 ` Rasmus Villemoes
2022-11-26 14:18 ` [PATCH v1 3/5] rtc: isl12022: Drop unneeded OF guards and of_match_ptr() Andy Shevchenko
2022-11-26 14:18 ` [PATCH v1 4/5] rtc: isl12022: Join string literals back Andy Shevchenko
2022-11-29 14:15 ` Rasmus Villemoes
2022-11-26 14:18 ` [PATCH v1 5/5] rtc: isl12022: sort header inclusion alphabetically Andy Shevchenko
2022-11-29 14:15 ` Rasmus Villemoes
2022-11-29 14:10 ` [PATCH v1 1/5] rtc: isl12022: Get rid of unneeded private struct isl12022 Rasmus Villemoes
2022-12-28 9:42 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y6wPfnRC3YeFxs3S@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox