Re: [PATCH v3] device property: fix of node refcount leak in fwnode_graph_get_next_endpoint()

Andy Shevchenko
2022-12-28T09:51:57Z

On Wed, Dec 28, 2022 at 10:46:12AM +0100, Greg KH wrote:
> On Wed, Dec 28, 2022 at 11:37:15AM +0200, Andy Shevchenko wrote:
> > On Wed, Nov 23, 2022 at 10:25:42AM +0800, Yang Yingliang wrote:
> > > The 'parent' returned by fwnode_graph_get_port_parent()
> > > with refcount incremented when 'prev' is not NULL, it
> > > needs be put when finish using it.
> > >
> > > Because the parent is const, introduce a new variable to
> > > store the returned fwnode, then put it before returning
> > > from fwnode_graph_get_next_endpoint().
> >
> > Rafael, Greg, is this went through the cracks?
>
> Yes, but still in my queue. I'll look at it when I get back from break.

Have a nice one!

--
With Best Regards,
Andy Shevchenko