From: Vinod Koul <vkoul@kernel.org>
To: "Péter Ujfalusi" <peter.ujfalusi@gmail.com>
Cc: Jayesh Choudhary <j-choudhary@ti.com>,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dmaengine: ti: k3-udma: drop loglevel for non-fatal probe deferral log
Date: Wed, 28 Dec 2022 16:32:54 +0530 [thread overview]
Message-ID: <Y6wiXlZh1MUL2WrF@matsya> (raw)
In-Reply-To: <f954e71b-043c-43bc-a692-530497de2d0b@gmail.com>
On 29-11-22, 18:28, Péter Ujfalusi wrote:
>
>
> On 28/11/2022 12:13, Jayesh Choudhary wrote:
> > Change the log level from dev_err() to dev_dbg() for non-fatal probe
> > deferral log for getting MSI domain.
> > This makes the kernel log clean and we do not get recurring logs
> > stating: "Failed to get MSI domain".
>
> Or not print at all?
that would be better one :-)
>
> Acked-by: Peter Ujfalusi <peter.ujfalusi@gmail.com>
>
> >
> > Signed-off-by: Jayesh Choudhary <j-choudhary@ti.com>
> > ---
> > drivers/dma/ti/k3-udma.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/dma/ti/k3-udma.c b/drivers/dma/ti/k3-udma.c
> > index ce8b80bb34d7..e540166cf4c7 100644
> > --- a/drivers/dma/ti/k3-udma.c
> > +++ b/drivers/dma/ti/k3-udma.c
> > @@ -5344,7 +5344,7 @@ static int udma_probe(struct platform_device *pdev)
> > dev->msi.domain = of_msi_get_domain(dev, dev->of_node,
> > DOMAIN_BUS_TI_SCI_INTA_MSI);
> > if (!dev->msi.domain) {
> > - dev_err(dev, "Failed to get MSI domain\n");
> > + dev_dbg(dev, "Failed to get MSI domain\n");
> > return -EPROBE_DEFER;
> > }
>
> --
> Péter
--
~Vinod
prev parent reply other threads:[~2022-12-28 11:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-28 10:13 [PATCH] dmaengine: ti: k3-udma: drop loglevel for non-fatal probe deferral log Jayesh Choudhary
2022-11-29 16:28 ` Péter Ujfalusi
2022-12-28 11:02 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y6wiXlZh1MUL2WrF@matsya \
--to=vkoul@kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=j-choudhary@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.ujfalusi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox