From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73F77C4167B for ; Wed, 28 Dec 2022 18:30:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232333AbiL1SaZ (ORCPT ); Wed, 28 Dec 2022 13:30:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59760 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231400AbiL1SaV (ORCPT ); Wed, 28 Dec 2022 13:30:21 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C87B313DCB for ; Wed, 28 Dec 2022 10:30:20 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 68D01B818BD for ; Wed, 28 Dec 2022 18:30:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A2C18C433EF; Wed, 28 Dec 2022 18:30:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1672252218; bh=8GdpfCPYNbZ7pONcybw0AZexxDzJ9PmxSxjOD45MToI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cMN8sn2qVZcrzRNGqHFFHegiRkzijJ7lgl63Nluh/32moJDMxsjBBpdfOHtOU2m/P JUZxv0u0XGMe/kTDCobfG+b7TcBZvMm0Q4s1a2Oha7ctEXj9ryy2aC97Mt2O9Qfz4p EM4BdlRjung9oxz/0osT1n6rkrsrTazQ2xn77BQSgRROGcMA5Wh8s4mXvCSowlG+o4 8ZJcLZrcVfEyr0IZLvSdIEwTzpcRbGOGIXq4q/Sffb+OMU6WW4gPwa7Cz+haYYqKaJ cm0n6r4+pJi0//NsLGHYXoaXer2sWhqyFJize9T7g27HkcJ+U31DzSwh0WR25lDlIn 4Iu49epuwIBPQ== Date: Wed, 28 Dec 2022 18:30:11 +0000 From: Conor Dooley To: Samuel Holland Cc: Palmer Dabbelt , Dmitry Osipenko , "Rafael J . Wysocki" , Albert Ou , Anup Patel , Atish Patra , Geert Uytterhoeven , Heiko Stuebner , Kai-Heng Feng , Luis Chamberlain , "Paul E. McKenney" , Paul Walmsley , Petr Mladek , YueHaibing , linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, tangmeng Subject: Re: [PATCH 0/3] riscv: sbi: Switch to the sys-off handler API Message-ID: References: <20221228161915.13194-1-samuel@sholland.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ATLP0lEXvRX45tso" Content-Disposition: inline In-Reply-To: <20221228161915.13194-1-samuel@sholland.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --ATLP0lEXvRX45tso Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hey Samuel, On Wed, Dec 28, 2022 at 10:19:12AM -0600, Samuel Holland wrote: > I want to convert the axp20x PMIC poweroff handler to use the sys-off > API, so it can be used as a fallback for if the SBI poweroff handler > is unavailable. But the SBI poweroff handler still uses pm_power_off, so > done alone, this would cause the axp20x callback to be called first, > before the SBI poweroff handler has a chance to run. >=20 > In order to prevent this change in behavior, the SBI poweroff handler > needs to be converted to the sys-off API first, at a higher priority. >=20 > This series performs the conversion, after accounting for the fact that > the SBI poweroff handler is registered quite early during boot. >=20 > The first patch is a dependency for both this series and the PSCI > series[1], so I would like to get at least patch 1 merged soon. >=20 > [1]: https://lore.kernel.org/lkml/20221105214841.7828-1-samuel@sholland.o= rg/ >=20 >=20 > Samuel Holland (3): > kernel/reboot: Use the static sys-off handler for any priority > riscv: sbi: Share the code for unsupported extension warnings > riscv: sbi: Switch to the sys-off handler API Not what other stuff has reboot support, so I gave it a whirl on PolarFire SoC & it seemed to work as expected: Tested-by: Conor Dooley Thanks, Conor. --ATLP0lEXvRX45tso Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCY6yLMwAKCRB4tDGHoIJi 0ivzAP9+SH0Lql0XKHnaLv07MiLUmZWgUzA9fyFMuC2SL6mJvAEA+nzYanZ4TgWy B8EyY10df0N49zc5ohweBmmjHCZz3A0= =7zvo -----END PGP SIGNATURE----- --ATLP0lEXvRX45tso--