From: Ingo Molnar <mingo@kernel.org>
To: Xin Li <xin3.li@intel.com>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org, tglx@linutronix.de,
mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com,
hpa@zytor.com, peterz@infradead.org, brgerst@gmail.com,
chang.seok.bae@intel.com, jgross@suse.com
Subject: Re: [PATCH v6 0/5] x86: Enable LKGS instruction
Date: Thu, 12 Jan 2023 13:13:20 +0100 [thread overview]
Message-ID: <Y7/5YPxbRE2AWgT0@gmail.com> (raw)
In-Reply-To: <20230112072032.35626-1-xin3.li@intel.com>
* Xin Li <xin3.li@intel.com> wrote:
> LKGS instruction is introduced with Intel FRED (flexible return and event
> delivery) specification. As LKGS is independent of FRED, we enable it as
> a standalone CPU feature.
>
> LKGS behaves like the MOV to GS instruction except that it loads the base
> address into the IA32_KERNEL_GS_BASE MSR instead of the GS segment’s
> descriptor cache, which is exactly what Linux kernel does to load user
> level GS base. Thus, with LKGS, there is no need to SWAPGS away from the
> kernel GS base.
Ok, this looks good to me.
I've applied the first 4 patches to tip:x86/cpu, as the instruction exists
in a public document and these patches are fine stand-alone as well, such
as the factoring out of load_gs_index() methods from a high-use low level
header into a new header file.
Planning to apply the final, LKGS enabler patch as well, unless there's any
objections from others?
Thanks,
Ingo
next prev parent reply other threads:[~2023-01-12 12:14 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-12 7:20 [PATCH v6 0/5] x86: Enable LKGS instruction Xin Li
2023-01-12 7:20 ` [PATCH v6 1/5] x86/cpufeature: add the cpu feature bit for LKGS Xin Li
2023-01-12 12:16 ` [tip: x86/cpu] x86/cpufeature: Add the CPU " tip-bot2 for H. Peter Anvin (Intel)
2023-01-12 7:20 ` [PATCH v6 2/5] x86/opcode: add the LKGS instruction to x86-opcode-map Xin Li
2023-01-12 12:16 ` [tip: x86/cpu] x86/opcode: Add " tip-bot2 for H. Peter Anvin (Intel)
2023-01-12 7:20 ` [PATCH v6 3/5] x86/gsseg: make asm_load_gs_index() take an u16 Xin Li
2023-01-12 12:16 ` [tip: x86/cpu] x86/gsseg: Make " tip-bot2 for H. Peter Anvin (Intel)
2023-01-12 7:20 ` [PATCH v6 4/5] x86/gsseg: move load_gs_index() to its own new header file Xin Li
2023-01-12 12:16 ` [tip: x86/cpu] x86/gsseg: Move " tip-bot2 for H. Peter Anvin (Intel)
2023-01-12 7:20 ` [PATCH v6 5/5] x86/gsseg: use the LKGS instruction if available for load_gs_index() Xin Li
2023-01-13 9:36 ` [tip: x86/cpu] x86/gsseg: Use " tip-bot2 for H. Peter Anvin (Intel)
2024-06-30 16:04 ` [PATCH v6 5/5] x86/gsseg: use " Borislav Petkov
2024-07-01 2:34 ` H. Peter Anvin
2024-07-01 6:08 ` Borislav Petkov
2024-07-01 6:31 ` H. Peter Anvin
2024-07-01 6:40 ` Borislav Petkov
2024-07-01 8:01 ` H. Peter Anvin
2024-07-01 9:47 ` Borislav Petkov
2023-01-12 12:13 ` Ingo Molnar [this message]
2023-01-12 14:57 ` [PATCH v6 0/5] x86: Enable LKGS instruction Peter Zijlstra
2023-01-13 13:29 ` Ingo Molnar
2023-01-13 18:26 ` Li, Xin3
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y7/5YPxbRE2AWgT0@gmail.com \
--to=mingo@kernel.org \
--cc=bp@alien8.de \
--cc=brgerst@gmail.com \
--cc=chang.seok.bae@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xin3.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox