Re: [RESEND PATCH 1/2] HID: Add driver for RC Simulator Controllers

Marcus Folkesson
2023-01-10T14:48:49Z

[-- Attachment #1: Type: text/plain, Size: 1040 bytes --]

Hi Benjamin,

On Mon, Sep 19, 2022 at 03:32:37PM +0200, Benjamin Tissoires wrote:
>
>

[...]

>
> I am back home, and I just tested that. I had a doubt, and it is indeed
> failing. You need the following change for this to be working (I need to
> send it as a proper patch after assessing it hasn't side effects)

Did it come up with any side effects? :-)

>
> ---
>
> diff --git a/drivers/hid/usbhid/hid-core.c b/drivers/hid/usbhid/hid-core.c
> index 13cce286247e..f37ffe2bd488 100644
> --- a/drivers/hid/usbhid/hid-core.c
> +++ b/drivers/hid/usbhid/hid-core.c
> @@ -275,6 +275,7 @@ static void hid_irq_in(struct urb *urb)
> int status;
> switch (urb->status) {
> + case -EOVERFLOW: /* happens with modified report descriptors */
> case 0: /* success */
> usbhid->retry_delay = 0;
> if (!test_bit(HID_OPENED, &usbhid->iofl))
> ---
>
> Cheers,
> Benjamin
>

Best regards,
Marcus Folkesson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]