From: Peter Zijlstra <peterz@infradead.org>
To: Boqun Feng <boqun.feng@gmail.com>
Cc: "Wedson Almeida Filho" <wedsonaf@gmail.com>,
rust-for-linux@vger.kernel.org, "Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
linux-kernel@vger.kernel.org, "Will Deacon" <will@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>
Subject: Re: [PATCH 1/7] rust: sync: add `Arc` for ref-counted allocations
Date: Tue, 10 Jan 2023 22:54:35 +0100 [thread overview]
Message-ID: <Y73em8F0zNzUbUfg@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <Y73aWaJ8gVHsG/Uq@boqun-archlinux>
On Tue, Jan 10, 2023 at 01:36:25PM -0800, Boqun Feng wrote:
> On Tue, Jan 10, 2023 at 10:20:50PM +0100, Peter Zijlstra wrote:
> > On Tue, Jan 10, 2023 at 12:22:47PM -0800, Boqun Feng wrote:
> >
> > > First, I'd really appreciate it that Will, Peter or Mark can take a look
> > > at the series and see if they are happy or not ;-)
> >
> > I only have 1 patch, and since I don't speak rust I have very limited
> > feedback. Having to use out-of-line functions seems sub-optimal, but
> > I suppose that's a limitation of the Rust-C bindings.
> >
> > Afaict this is like C++ shared_ptr<> and using refcount_t seems okay for
> > that, not sure what else you're asking.
> >
>
> Thanks! I failed to find that you were only Cc for the first patch.. I
> cannot speak for Wedson, but the rest of the patchset are all based on
> the first patch and purely in Rust, maybe he was avoiding to "spam" your
> inbox ;-)
>
> While we are at it, for a general case, say we provide Rust's interface
> of task/kthread managament, do you prefer to seeing the whole patchset
> (including how Rust side provides the APIs) or seeing only the patch
> that interacts with C?
>
> Again, trying to find the sweet spot for collaboration ;-)
Always all patches. The more effort I need to do to find sometihng the
smaller the chance I will. Also, I get so much email, I've long since
given up on reading it all.
next prev parent reply other threads:[~2023-01-10 21:54 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-28 6:03 [PATCH 1/7] rust: sync: add `Arc` for ref-counted allocations Wedson Almeida Filho
2022-12-28 6:03 ` [PATCH 2/7] rust: sync: allow type of `self` to be `Arc<T>` or variants Wedson Almeida Filho
2022-12-28 10:03 ` Alice Ryhl
2022-12-31 19:37 ` Gary Guo
2023-01-04 16:12 ` Vincenzo
2022-12-28 6:03 ` [PATCH 3/7] rust: sync: allow coercion from `Arc<T>` to `Arc<U>` Wedson Almeida Filho
2022-12-28 10:03 ` Alice Ryhl
2022-12-31 19:37 ` Gary Guo
2023-01-04 16:13 ` Vincenzo
2022-12-28 6:03 ` [PATCH 4/7] rust: sync: introduce `ArcBorrow` Wedson Almeida Filho
2022-12-28 7:15 ` Laine Taffin Altman
2022-12-28 10:03 ` Alice Ryhl
2022-12-31 19:43 ` Gary Guo
2023-01-04 15:29 ` Wedson Almeida Filho
2023-01-04 16:06 ` Emilio Cobos Álvarez
2023-01-04 17:52 ` Wedson Almeida Filho
2023-01-16 22:07 ` Gary Guo
2023-01-21 0:44 ` Boqun Feng
2023-01-16 22:42 ` Vincenzo Palazzo
2022-12-28 6:03 ` [PATCH 5/7] rust: sync: allow type of `self` to be `ArcBorrow<T>` Wedson Almeida Filho
2022-12-28 10:04 ` Alice Ryhl
2022-12-31 19:44 ` Gary Guo
2023-01-04 16:18 ` Vincenzo
2022-12-28 6:03 ` [PATCH 6/7] rust: sync: introduce `UniqueArc` Wedson Almeida Filho
2022-12-28 7:19 ` Laine Taffin Altman
2022-12-31 19:46 ` Gary Guo
2022-12-28 10:04 ` Alice Ryhl
2022-12-31 19:47 ` Gary Guo
2023-01-04 16:21 ` Vincenzo
2022-12-28 6:03 ` [PATCH 7/7] rust: sync: add support for dispatching on Arc and ArcBorrow Wedson Almeida Filho
2022-12-28 7:24 ` Laine Taffin Altman
2022-12-31 19:51 ` Gary Guo
2022-12-28 10:04 ` Alice Ryhl
2022-12-31 19:52 ` Gary Guo
2023-01-04 16:26 ` Vincenzo
2022-12-28 7:09 ` [PATCH 1/7] rust: sync: add `Arc` for ref-counted allocations Laine Taffin Altman
2022-12-28 7:27 ` Wedson Almeida Filho
2022-12-28 7:32 ` Laine Taffin Altman
2022-12-28 10:03 ` Alice Ryhl
2022-12-28 10:14 ` Wedson Almeida Filho
2022-12-28 10:38 ` Alice Ryhl
2022-12-31 19:55 ` Gary Guo
2023-01-04 16:08 ` Vincenzo
2023-01-10 20:22 ` Boqun Feng
2023-01-10 21:20 ` Peter Zijlstra
2023-01-10 21:36 ` Boqun Feng
2023-01-10 21:54 ` Peter Zijlstra [this message]
2023-01-16 21:06 ` Boqun Feng
2023-01-16 23:34 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y73em8F0zNzUbUfg@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=alex.gaynor@gmail.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=wedsonaf@gmail.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox