From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46CAAC54EBC for ; Wed, 11 Jan 2023 01:21:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235262AbjAKBVK (ORCPT ); Tue, 10 Jan 2023 20:21:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44286 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234163AbjAKBVH (ORCPT ); Tue, 10 Jan 2023 20:21:07 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1CB705F9C; Tue, 10 Jan 2023 17:21:02 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 95A8161999; Wed, 11 Jan 2023 01:21:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D89D3C433D2; Wed, 11 Jan 2023 01:21:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1673400061; bh=L2t71BZAowgZYZQjAiJUgHg5t13KDoB6HhVsNJIeyNY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=L7JoI+MkIawQAMHxRrqPYTlHdXS1ivbHKTc5leT23+JiDvlMHtU4+kbetF/XDoZ3z wHx5z2mXt4kHennZKTdPXPoxDtc2Uqe4JeAU8XLPa0CthVH+S5GpUCwdgEB9QoorPX gKJ3wmfaUNzFZSLa2WvsJHhrThj9XXONmQ/dl4aoP/ImabSfQZRRdMumsDnNq8oyR+ beVufNdFQgK3Ga94ViB6iQl1o9szq3b4GlJGNclfXC/pQYLJeYmEXGT3MeTL/B8mDr A+Wlrlw3J6mRTvf+Bdpbii9rvDMaGl1DwkT4T2HYhEOpLyHiZv0AREGs7qOQ/pxu0I AGH9ODalRgAIQ== Date: Tue, 10 Jan 2023 17:20:59 -0800 From: Jaegeuk Kim To: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Cc: stable@vger.kernel.org, Randall Huang Subject: Re: [PATCH v2] f2fs: retry to update the inode page given EIO Message-ID: References: <20230105233908.1030651-1-jaegeuk@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230105233908.1030651-1-jaegeuk@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In f2fs_update_inode_page, f2fs_get_node_page handles EIO along with f2fs_handle_page_eio that stops checkpoint, if the disk couldn't be recovered. As a result, we don't need to stop checkpoint right away given single EIO. Cc: stable@vger.kernel.org Signed-off-by: Randall Huang Signed-off-by: Jaegeuk Kim --- Change log from v1: - fix a bug fs/f2fs/inode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/f2fs/inode.c b/fs/f2fs/inode.c index ff6cf66ed46b..2ed7a621fdf1 100644 --- a/fs/f2fs/inode.c +++ b/fs/f2fs/inode.c @@ -719,7 +719,7 @@ void f2fs_update_inode_page(struct inode *inode) if (IS_ERR(node_page)) { int err = PTR_ERR(node_page); - if (err == -ENOMEM) { + if (err == -ENOMEM || (err == -EIO && !f2fs_cp_error(sbi))) { cond_resched(); goto retry; } else if (err != -ENOENT) { -- 2.39.0.314.g84b9a713c41-goog