From: Pengfei Xu <pengfei.xu@intel.com>
To: Javier Martinez Canillas <javierm@redhat.com>
Cc: <skhan@linuxfoundation.org>, <shuah@kernel.org>,
<linux-kselftest@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Heng Su <heng.su@intel.com>, <akpm@linux-foundation.org>
Subject: Re: [PATCH v1 1/1] selftests/filesystems: Grant executable permission to run_fat_tests.sh
Date: Thu, 12 Jan 2023 10:10:36 +0800 [thread overview]
Message-ID: <Y79sHLMU4BYEwFAn@xpf.sh.intel.com> (raw)
In-Reply-To: <667c1b8e-b46c-c830-8f01-9e97e64e4e4e@redhat.com>
Hi Javier Martinez Canillas,
On 2023-01-11 at 15:47:00 +0100, Javier Martinez Canillas wrote:
> Hello Pengfei Xu,
>
> On 1/11/23 09:15, Pengfei Xu wrote:
> > When use tools/testing/selftests/kselftest_install.sh to make the
> > kselftest-list.txt under tools/testing/selftests/kselftest_install.
> >
> > Then use tools/testing/selftests/kselftest_install/run_kselftest.sh to
> > run all the kselftests in kselftest-list.txt, it will be blocked by
> > case "filesystems/fat: run_fat_tests.sh" with "Warning: file run_fat_tests.sh
> > is not executable", so grant executable permission to run_fat_tests.sh to
> > fix this issue.
> >
> > Fixes: dd7c9be330d8 ("selftests/filesystems: add a vfat RENAME_EXCHANGE test")
> > Signed-off-by: Pengfei Xu <pengfei.xu@intel.com>
> > ---
>
> Indeed, thanks for fixing this.
>
> Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
Thanks for your tag, thank you and Andrew Morton, and I'm glad it's helpful.
Thanks!
BR.
>
> I wonder how I didn't get this when running the test with:
>
> make TARGETS="filesystems/fat" kselftest
>
> --
> Best regards,
>
> Javier Martinez Canillas
> Core Platforms
> Red Hat
>
prev parent reply other threads:[~2023-01-12 2:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1673424747.git.pengfei.xu@intel.com>
2023-01-11 8:15 ` [PATCH v1 1/1] selftests/filesystems: Grant executable permission to run_fat_tests.sh Pengfei Xu
2023-01-11 14:47 ` Javier Martinez Canillas
2023-01-12 2:10 ` Pengfei Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y79sHLMU4BYEwFAn@xpf.sh.intel.com \
--to=pengfei.xu@intel.com \
--cc=akpm@linux-foundation.org \
--cc=heng.su@intel.com \
--cc=javierm@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox