* [PATCH v1 1/1] selftests/filesystems: Grant executable permission to run_fat_tests.sh [not found] <cover.1673424747.git.pengfei.xu@intel.com> @ 2023-01-11 8:15 ` Pengfei Xu 2023-01-11 14:47 ` Javier Martinez Canillas 0 siblings, 1 reply; 3+ messages in thread From: Pengfei Xu @ 2023-01-11 8:15 UTC (permalink / raw) To: javierm, skhan, shuah Cc: linux-kselftest, linux-kernel, Pengfei Xu, Heng Su, akpm When use tools/testing/selftests/kselftest_install.sh to make the kselftest-list.txt under tools/testing/selftests/kselftest_install. Then use tools/testing/selftests/kselftest_install/run_kselftest.sh to run all the kselftests in kselftest-list.txt, it will be blocked by case "filesystems/fat: run_fat_tests.sh" with "Warning: file run_fat_tests.sh is not executable", so grant executable permission to run_fat_tests.sh to fix this issue. Fixes: dd7c9be330d8 ("selftests/filesystems: add a vfat RENAME_EXCHANGE test") Signed-off-by: Pengfei Xu <pengfei.xu@intel.com> --- tools/testing/selftests/filesystems/fat/run_fat_tests.sh | 0 1 file changed, 0 insertions(+), 0 deletions(-) mode change 100644 => 100755 tools/testing/selftests/filesystems/fat/run_fat_tests.sh diff --git a/tools/testing/selftests/filesystems/fat/run_fat_tests.sh b/tools/testing/selftests/filesystems/fat/run_fat_tests.sh old mode 100644 new mode 100755 -- 2.31.1 ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1 1/1] selftests/filesystems: Grant executable permission to run_fat_tests.sh 2023-01-11 8:15 ` [PATCH v1 1/1] selftests/filesystems: Grant executable permission to run_fat_tests.sh Pengfei Xu @ 2023-01-11 14:47 ` Javier Martinez Canillas 2023-01-12 2:10 ` Pengfei Xu 0 siblings, 1 reply; 3+ messages in thread From: Javier Martinez Canillas @ 2023-01-11 14:47 UTC (permalink / raw) To: Pengfei Xu, skhan, shuah; +Cc: linux-kselftest, linux-kernel, Heng Su, akpm Hello Pengfei Xu, On 1/11/23 09:15, Pengfei Xu wrote: > When use tools/testing/selftests/kselftest_install.sh to make the > kselftest-list.txt under tools/testing/selftests/kselftest_install. > > Then use tools/testing/selftests/kselftest_install/run_kselftest.sh to > run all the kselftests in kselftest-list.txt, it will be blocked by > case "filesystems/fat: run_fat_tests.sh" with "Warning: file run_fat_tests.sh > is not executable", so grant executable permission to run_fat_tests.sh to > fix this issue. > > Fixes: dd7c9be330d8 ("selftests/filesystems: add a vfat RENAME_EXCHANGE test") > Signed-off-by: Pengfei Xu <pengfei.xu@intel.com> > --- Indeed, thanks for fixing this. Reviewed-by: Javier Martinez Canillas <javierm@redhat.com> I wonder how I didn't get this when running the test with: make TARGETS="filesystems/fat" kselftest -- Best regards, Javier Martinez Canillas Core Platforms Red Hat ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1 1/1] selftests/filesystems: Grant executable permission to run_fat_tests.sh 2023-01-11 14:47 ` Javier Martinez Canillas @ 2023-01-12 2:10 ` Pengfei Xu 0 siblings, 0 replies; 3+ messages in thread From: Pengfei Xu @ 2023-01-12 2:10 UTC (permalink / raw) To: Javier Martinez Canillas Cc: skhan, shuah, linux-kselftest, linux-kernel, Heng Su, akpm Hi Javier Martinez Canillas, On 2023-01-11 at 15:47:00 +0100, Javier Martinez Canillas wrote: > Hello Pengfei Xu, > > On 1/11/23 09:15, Pengfei Xu wrote: > > When use tools/testing/selftests/kselftest_install.sh to make the > > kselftest-list.txt under tools/testing/selftests/kselftest_install. > > > > Then use tools/testing/selftests/kselftest_install/run_kselftest.sh to > > run all the kselftests in kselftest-list.txt, it will be blocked by > > case "filesystems/fat: run_fat_tests.sh" with "Warning: file run_fat_tests.sh > > is not executable", so grant executable permission to run_fat_tests.sh to > > fix this issue. > > > > Fixes: dd7c9be330d8 ("selftests/filesystems: add a vfat RENAME_EXCHANGE test") > > Signed-off-by: Pengfei Xu <pengfei.xu@intel.com> > > --- > > Indeed, thanks for fixing this. > > Reviewed-by: Javier Martinez Canillas <javierm@redhat.com> Thanks for your tag, thank you and Andrew Morton, and I'm glad it's helpful. Thanks! BR. > > I wonder how I didn't get this when running the test with: > > make TARGETS="filesystems/fat" kselftest > > -- > Best regards, > > Javier Martinez Canillas > Core Platforms > Red Hat > ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-01-12 2:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <cover.1673424747.git.pengfei.xu@intel.com>
2023-01-11 8:15 ` [PATCH v1 1/1] selftests/filesystems: Grant executable permission to run_fat_tests.sh Pengfei Xu
2023-01-11 14:47 ` Javier Martinez Canillas
2023-01-12 2:10 ` Pengfei Xu
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox