From: Greg KH <gregkh@linuxfoundation.org>
To: Yoochan Lee <yoochan1026@gmail.com>
Cc: matt.hsiao@hpe.com, arnd@arndb.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] misc: hpilo: Fix use-after-free in ilo_open
Date: Sat, 31 Dec 2022 12:46:53 +0100 [thread overview]
Message-ID: <Y7AhLWSPE+2hnZ2I@kroah.com> (raw)
In-Reply-To: <CALQpDLfMjAE9_VtMO6e_iiPrciFNbksLQT3AB3QTGwZCNf5=sA@mail.gmail.com>
On Sat, Dec 31, 2022 at 07:05:36PM +0900, Yoochan Lee wrote:
> Hi,
>
> I haven't tested with a physical device cause I don't have a real device.
> I found this bug through static analysis.
Then please verify that it actually is a bug and that you have fixed it
properly. To send patches that are broken wastes everyone's time :(
Also, you did not properly describe how the static analysis happened or
what tools reported it as is required.
> This type of bug is similar to [1] and [2].
>
> And I'm sorry that my patch is incorrect.
> It's my first time patching a Linux kernel myself.
I suggest taking the tutorial on kernelnewbies.org and working in the
drivers/staging/* portion of the kernel first, so that you can learn how
this all works. Do not dive in and assume that fixing issues that a
random tool spits out is even correct to do.
good luck!
greg k-h
next prev parent reply other threads:[~2022-12-31 11:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-31 5:53 [PATCH] misc: hpilo: Fix use-after-free in ilo_open Yoochan Lee
2022-12-31 8:50 ` kernel test robot
2022-12-31 8:56 ` Yoochan Lee
2022-12-31 9:23 ` Yoochan Lee
2022-12-31 9:57 ` Greg KH
2022-12-31 9:58 ` Greg KH
2022-12-31 10:05 ` Yoochan Lee
2022-12-31 11:46 ` Greg KH [this message]
2022-12-31 13:06 ` Yoochan Lee
2022-12-31 13:48 ` Greg KH
2023-01-01 1:19 ` Yoochan Lee
2023-01-03 2:35 ` Matt Hsiao
2022-12-31 10:31 ` kernel test robot
2022-12-31 10:31 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y7AhLWSPE+2hnZ2I@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.hsiao@hpe.com \
--cc=yoochan1026@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox