From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
Lars-Peter Clausen <lars@metafoo.de>
Subject: Re: [PATCH v1 1/2] iio: adc: ti-adc128s052: Switch to use spi_get_device_match_data()
Date: Sat, 31 Dec 2022 20:24:24 +0200 [thread overview]
Message-ID: <Y7B+WK9Qqth+j85X@smile.fi.intel.com> (raw)
In-Reply-To: <20221231144558.44720f4d@jic23-huawei>
On Sat, Dec 31, 2022 at 02:45:58PM +0000, Jonathan Cameron wrote:
> On Wed, 28 Dec 2022 11:59:53 +0200
> Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
...
> I should have been more specific though I do mention rebasing to get the
> patch above.. Doesn't build with it.
>
> Signature of spi_get_device_match_data is:
> extern const void *
> spi_get_device_match_data(const struct spi_device *sdev);
>
> and you are passing it a struct device * which rather implies you didn't
> successfully build test this.
Definitely. Thanks for spotting this, I'll investigate what happened on my side
that it wasn't built.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2022-12-31 18:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-14 11:49 [PATCH v1 1/2] iio: adc: ti-adc128s052: Switch to use spi_get_device_match_data() Andy Shevchenko
2022-12-14 11:49 ` [PATCH v1 2/2] iio: adc: ti-adc128s052: Drop anti-pattern of ACPI_PTR() use Andy Shevchenko
2022-12-23 15:24 ` Jonathan Cameron
2022-12-14 13:10 ` [PATCH v1 1/2] iio: adc: ti-adc128s052: Switch to use spi_get_device_match_data() kernel test robot
2022-12-14 17:02 ` kernel test robot
2022-12-23 15:22 ` Jonathan Cameron
2022-12-23 15:44 ` Jonathan Cameron
2022-12-28 9:59 ` Andy Shevchenko
2022-12-31 14:45 ` Jonathan Cameron
2022-12-31 18:24 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y7B+WK9Qqth+j85X@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox