From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4FD5C4708D for ; Mon, 2 Jan 2023 15:39:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236215AbjABPjY (ORCPT ); Mon, 2 Jan 2023 10:39:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42184 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232151AbjABPjW (ORCPT ); Mon, 2 Jan 2023 10:39:22 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2FF53C0; Mon, 2 Jan 2023 07:39:21 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id CCFFFB80D3E; Mon, 2 Jan 2023 15:39:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8D34AC433D2; Mon, 2 Jan 2023 15:39:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1672673958; bh=BBtjVOXgxCVISiBLCC+DVEdmz0AwEae6BOmktTKerbc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ggpgKQ1kZYLWA5b7RqSJ59Wl9DovrYCYdgCDez7yfmivoHty8maWJVPmdpTqu1UF8 S3NCA3tvPnqEqZGoKYyHFbQrLuukEJc+gAuP2NwSegBgStjXozEFFUmz0xWx5a0ZtJ Rhlv63AXr9WWy7kJN00DliptdkTRC2UlQ2LcsfD7Kd8u5XAC9ItciFe9sFXhRWFTGu AfuhGHd7gjwLpzhleerPHeVxthfxYhq/tPirAFfCJENOC0zAbeb6jAxEdByLUEFKmQ jyQuu7lYov8IMPuOXmx4pykLRn7nfjQIzNZHKGtJiy75+beqJY8TD/QvavCza1FLK1 YyCk+ipXRxt/g== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1pCMuV-0008Ap-4t; Mon, 02 Jan 2023 16:39:35 +0100 Date: Mon, 2 Jan 2023 16:39:35 +0100 From: Johan Hovold To: Krzysztof Kozlowski Cc: Johan Hovold , Bjorn Andersson , Andy Gross , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Srinivas Kandagatla , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/6] arm64: dts: qcom: sc8280xp-x13s: disable soundcard Message-ID: References: <20230102105038.8074-1-johan+linaro@kernel.org> <20230102105038.8074-2-johan+linaro@kernel.org> <81e3994e-49d9-ea5b-b055-cbcc737a6e37@linaro.org> <8bd6487a-3ae7-f7c1-e478-1effd68700d3@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8bd6487a-3ae7-f7c1-e478-1effd68700d3@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 02, 2023 at 04:28:56PM +0100, Krzysztof Kozlowski wrote: > On 02/01/2023 16:24, Johan Hovold wrote: > > On Mon, Jan 02, 2023 at 04:12:35PM +0100, Krzysztof Kozlowski wrote: > >> On 02/01/2023 16:07, Johan Hovold wrote: > >>> On Mon, Jan 02, 2023 at 01:25:38PM +0100, Krzysztof Kozlowski wrote: > >>>> On 02/01/2023 11:50, Johan Hovold wrote: > >>>>> Driver support for the X13s soundcard is not yet in place so disable it > >>>>> for now to avoid probe failures such as: > >>>>> > >>>>> [ 11.077727] qcom-prm gprsvc:service:2:2: DSP returned error[100100f] 1 > >>>>> [ 11.077926] rx_macro: probe of 3200000.rxmacro failed with error -22 > >>>>> [ 21.221104] platform 3210000.soundwire-controller: deferred probe pending > >>>>> > >>>>> Signed-off-by: Johan Hovold > >>>>> --- > >>>>> .../boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 12 ++++++++++-- > >>>>> 1 file changed, 10 insertions(+), 2 deletions(-) > >>>>> wcd_tx: wcd9380-tx@0,3 { > >>>>> compatible = "sdw20217010d00"; > >>>>> @@ -781,6 +787,8 @@ &vamacro { > >>>>> pinctrl-names = "default"; > >>>>> vdd-micb-supply = <&vreg_s10b>; > >>>>> qcom,dmic-sample-rate = <600000>; > >>>>> + > >>>>> + status = "disabled"; > >>>> > >>>> That's a double disable. > >>> > >>> Yes, that's on purpose. We're temporarily disabling these nodes instead > >>> of reverting the series which should not have been merged. > >> > >> I don't get why disabling something twice is anyhow related to > >> "temporarily disable". One disable is enough for temporary or permanent > >> disables. > > > > It clearly shows that this was done on purpose and indicates which > > properties need to be changed to "okay" once we have actual support. > > No, it shows nothing clearly as from time to time we got duplicated > properties and it's a simply mistake. The double disable without any > comment looks like mistake, not intentional code. It's not a mistake. It's intentional. And I don't want to spend hours on this because of someone else's cock-up. > >>> > >>> Once we have driver support, these properties will be updated again. > >> > >> Linux kernel is not the only consumer of DTS, thus having or not having > >> the support in the kernel is not reason to disable pieces of it. > >> Assuming the DTS is correct, of course, because maybe that's the problem? > > > > Okay, let's revert these sound dts changes then until we have support. > > We have no idea if the dts changes are correct as sound still depends > > on out-of-tree hacks. > > > > People are using -next for development and I don't want to see them > > toast their speakers because we failed get the dependencies merged > > before merging the dts changes which is how we normally do this. > > If the error is in DTS, yeah, revert or disable is a way. But if the > issue is in the incomplete or broken Linux drivers, then these should be > changed, e.g. intentionally fail probing, skip new devices, drop new > compatible etc. And how long does it take for that to propagate and isn't the response just going go to be "well then fix the driver". I think you're just being unreasonable here. If Bjorn could rebase his tree, he could simply drop these for now as sound support was clearly not ready. Since that isn't the case we need to at least try to be constructive and figure out a reasonable alternative. While "Linux isn't the only consumer" is a true statement, it really is not relevant just because there are some dts changes in Bjorn's tree which should not be there. Johan