From: Johan Hovold <johan@kernel.org>
To: Konrad Dybcio <konrad.dybcio@linaro.org>
Cc: Johan Hovold <johan+linaro@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Andy Gross <agross@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/6] arm64: dts: qcom: sm8450-hdk: fix wcd938x codec node
Date: Mon, 2 Jan 2023 12:42:54 +0100 [thread overview]
Message-ID: <Y7LDPgc+dnAMqwHU@hovoldconsulting.com> (raw)
In-Reply-To: <6447bb2f-0ef1-a8a8-4b94-875e16954ca6@linaro.org>
On Mon, Jan 02, 2023 at 12:16:44PM +0100, Konrad Dybcio wrote:
>
>
> On 2.01.2023 11:50, Johan Hovold wrote:
> > The wcd938x codec is not a memory-mapped device and does not belong
> > under the soc node.
> >
> > Move the node to the root node to avoid DT validation failures.
> >
> > Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> > ---
> Third patch concerning the audio codec and third different
> order of properties :/ Please consolidate that.
It's arguably a separate change (even if I included it for the disabled
x13s node). I'm fixing the fact that the node should not have been added
under 'soc' in the first place.
Reordering properties can be done as a follow up if anyone cares enough,
even if I could possibly have renamed the node when moving it.
Johan
next prev parent reply other threads:[~2023-01-02 11:43 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-02 10:50 [PATCH 0/6] arm64: dts: qcom: disable x13s sound + cleanups Johan Hovold
2023-01-02 10:50 ` [PATCH 1/6] arm64: dts: qcom: sc8280xp-x13s: disable soundcard Johan Hovold
2023-01-02 12:25 ` Krzysztof Kozlowski
2023-01-02 15:07 ` Johan Hovold
2023-01-02 15:12 ` Krzysztof Kozlowski
2023-01-02 15:24 ` Johan Hovold
2023-01-02 15:28 ` Krzysztof Kozlowski
2023-01-02 15:39 ` Johan Hovold
2023-01-02 15:46 ` Krzysztof Kozlowski
2023-01-02 15:58 ` Johan Hovold
2023-01-02 16:13 ` Krzysztof Kozlowski
2023-01-02 16:52 ` Johan Hovold
2023-01-02 10:50 ` [PATCH 2/6] arm64: dts: qcom: sc8280xp: disable sound nodes Johan Hovold
2023-01-02 11:13 ` Konrad Dybcio
2023-01-02 12:29 ` Krzysztof Kozlowski
2023-01-02 15:15 ` Johan Hovold
2023-01-02 17:17 ` Johan Hovold
2023-01-02 17:20 ` Konrad Dybcio
2023-01-02 10:50 ` [PATCH 3/6] arm64: dts: qcom: sc8280xp: clean up tx-macro node Johan Hovold
2023-01-02 11:13 ` Konrad Dybcio
2023-01-02 10:50 ` [PATCH 4/6] arm64: dts: qcom: sc8280xp-x13s: fix wcd938x codec node Johan Hovold
2023-01-02 11:14 ` Konrad Dybcio
2023-01-02 10:50 ` [PATCH 5/6] arm64: dts: qcom: sm8250-mtp: " Johan Hovold
2023-01-02 11:15 ` Konrad Dybcio
2023-01-02 11:22 ` Johan Hovold
2023-01-02 12:20 ` Krzysztof Kozlowski
2023-01-02 15:03 ` Johan Hovold
2023-01-02 15:09 ` Krzysztof Kozlowski
2023-01-02 15:18 ` Johan Hovold
2023-01-02 15:22 ` Krzysztof Kozlowski
2023-01-02 15:28 ` Johan Hovold
2023-01-02 10:50 ` [PATCH 6/6] arm64: dts: qcom: sm8450-hdk: " Johan Hovold
2023-01-02 11:16 ` Konrad Dybcio
2023-01-02 11:42 ` Johan Hovold [this message]
2023-01-02 12:23 ` Krzysztof Kozlowski
2023-01-02 12:24 ` Krzysztof Kozlowski
2023-01-02 15:05 ` Johan Hovold
2023-01-02 15:09 ` Krzysztof Kozlowski
2023-01-02 15:18 ` Johan Hovold
2023-01-02 15:24 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y7LDPgc+dnAMqwHU@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=johan+linaro@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox