From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCA94C3DA7A for ; Mon, 2 Jan 2023 13:11:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232835AbjABNLK (ORCPT ); Mon, 2 Jan 2023 08:11:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60784 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229526AbjABNLH (ORCPT ); Mon, 2 Jan 2023 08:11:07 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8169AF1E; Mon, 2 Jan 2023 05:11:06 -0800 (PST) Received: from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi [213.243.189.158]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id EA3137C5; Mon, 2 Jan 2023 14:11:04 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1672665065; bh=OK4A1KfGEclvuJXN/ybxjJzeZRWRpirRlikGcWdNS4I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DaN9FihJfEPPW9Y2altvxtwA3gvrPKHfBr0KXpFEkl9Obd+MuAqHiUvB6LkQBdHRM m+jWTdU9VrGaLul/vGbwrGq4HesPTxThhqT4CuQ/pYzTp/DwKP5HeQuDytY7O6Efxv sQGxRsebnkVVAPudtNUOZhXp455WfSG3i2jhRXzM= Date: Mon, 2 Jan 2023 15:11:01 +0200 From: Laurent Pinchart To: Rahul T R Cc: dri-devel@lists.freedesktop.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, tomi.valkeinen@ideasonboard.com, andrzej.hajda@intel.com, narmstrong@baylibre.com, robert.foss@linaro.org, jonas@kwiboo.se, jernej.skrabec@gmail.com, airlied@linux.ie, daniel@ffwll.ch, p.zabel@pengutronix.de, linux-kernel@vger.kernel.org, jpawar@cadence.com, sjakhade@cadence.com, mparab@cadence.com, a-bhatia1@ti.com, devicetree@vger.kernel.org, vigneshr@ti.com, lee.jones@linaro.org, Rob Herring Subject: Re: [PATCH v10 2/5] dt-bindings: display: bridge: cdns,dsi: Add compatible for dsi on j721e Message-ID: References: <20230102100942.1828-1-r-ravikumar@ti.com> <20230102100942.1828-3-r-ravikumar@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230102100942.1828-3-r-ravikumar@ti.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rahul, Thank you for the patch. On Mon, Jan 02, 2023 at 03:39:39PM +0530, Rahul T R wrote: > Add compatible to support dsi bridge on j721e > > Signed-off-by: Rahul T R > Reviewed-by: Rob Herring Reviewed-by: Laurent Pinchart > --- > .../bindings/display/bridge/cdns,dsi.yaml | 25 ++++++++++++++++++- > 1 file changed, 24 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/display/bridge/cdns,dsi.yaml b/Documentation/devicetree/bindings/display/bridge/cdns,dsi.yaml > index 3161c33093c1..23060324d16e 100644 > --- a/Documentation/devicetree/bindings/display/bridge/cdns,dsi.yaml > +++ b/Documentation/devicetree/bindings/display/bridge/cdns,dsi.yaml > @@ -16,9 +16,15 @@ properties: > compatible: > enum: > - cdns,dsi > + - ti,j721e-dsi > > reg: > - maxItems: 1 > + minItems: 1 > + items: > + - description: > + Register block for controller's registers. > + - description: > + Register block for wrapper settings registers in case of TI J7 SoCs. > > clocks: > items: > @@ -67,6 +73,23 @@ properties: > allOf: > - $ref: ../dsi-controller.yaml# > > + - if: > + properties: > + compatible: > + contains: > + const: ti,j721e-dsi > + then: > + properties: > + reg: > + minItems: 2 > + maxItems: 2 > + power-domains: > + maxItems: 1 > + else: > + properties: > + reg: > + maxItems: 1 > + > required: > - compatible > - reg -- Regards, Laurent Pinchart