From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 368B3C3DA7A for ; Mon, 2 Jan 2023 19:00:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235893AbjABTAr (ORCPT ); Mon, 2 Jan 2023 14:00:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36520 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235261AbjABTAm (ORCPT ); Mon, 2 Jan 2023 14:00:42 -0500 Received: from mailrelay2-1.pub.mailoutpod2-cph3.one.com (mailrelay2-1.pub.mailoutpod2-cph3.one.com [IPv6:2a02:2350:5:401::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 23FEAF21 for ; Mon, 2 Jan 2023 11:00:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ravnborg.org; s=rsa2; h=in-reply-to:content-type:mime-version:references:message-id:subject:cc:to: from:date:from; bh=EQk+1kOAMVr8RWq04biVbUG5x442199Y9So5U/pNTxw=; b=rQQD8bxuv8Pgr1oC96farSkjWukdP6oP9yQypSyjEo4DUIPdhl62ZjNYyaLd5ZxDra3UUKoJKM8Ac YAJsgen/5rQJ9Fq5U64E+/mmNoYz6GvwiEPg4EwUMezMddKjkd1GfHyz0bqSYf10WraLdOn9IaTBvK 6TFSQoF5eOZXo5J/L5qRx/A83Lizm18nFeb1S4zGpk8HWr1h95/fkQ1FlMueALOpM4o2VSDGupPfo1 n+Q6Mr3b7HjBjj7+vSXShi3Zcel92+eUXgyNbPZTd6BelRZUj0sPlf2oQqy6KX4fg1VcSPv+oxgkFW IGH+vxRlSD0mxg8bZBl8dFT/Kz6nuBg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ravnborg.org; s=ed2; h=in-reply-to:content-type:mime-version:references:message-id:subject:cc:to: from:date:from; bh=EQk+1kOAMVr8RWq04biVbUG5x442199Y9So5U/pNTxw=; b=K46vGaMogCk+vHo9VPQrAC0tZwR/vCA7/M7h/PYk3t9cxj8G1WhbgPTZ/XaOwNIJlfu7ehEWGqpgJ n9b3McnBQ== X-HalOne-ID: be9e8061-8acf-11ed-a2ca-93f0a866dfbb Received: from ravnborg.org (2-105-2-98-cable.dk.customer.tdc.net [2.105.2.98]) by mailrelay2 (Halon) with ESMTPSA id be9e8061-8acf-11ed-a2ca-93f0a866dfbb; Mon, 02 Jan 2023 19:00:39 +0000 (UTC) Date: Mon, 2 Jan 2023 20:00:37 +0100 From: Sam Ravnborg To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, Ondrej Jirman , Purism Kernel Team , Thomas Zimmermann , Guido =?iso-8859-1?Q?G=FCnther?= , Thierry Reding , dri-devel@lists.freedesktop.org Subject: Re: [PATCH 00/14] drm/panel: Make panel drivers use existing DSI write macros Message-ID: References: <20221228014757.3170486-1-javierm@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221228014757.3170486-1-javierm@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Javier. On Wed, Dec 28, 2022 at 02:47:43AM +0100, Javier Martinez Canillas wrote: > Hello, > > This series contains cleanups for DRM panel drivers that define their own > DSI write macros instead of using what's already in . > > The changes are quite trivial but I've only tested this with allmodconfig > and `make M=drivers/gpu/drm/panel/` so please review and testing would be > highly appreciated. Nice cleanup - I like it. In most of the patches there is some trivial indent that should be fixed, I think I noted it everywhere. Sorry - but no testing. The last patch is buggy - see the comment. I suggest to land patch 1 now (with the fix), this makes it easier for others to test on top of drm-misc-next. Sam > > Best regards, > Javier > > > Javier Martinez Canillas (14): > drm/mipi-dsi: Add a mipi_dsi_dcs_write_seq() macro > drm/panel-asus-z00t-tm5p5-n35596: Drop custom DSI write macros > drm/panel-sitronix-st7703: Drop custom DSI write macros > drm/panel-leadtek-ltk050h3146w: Drop custom DSI write macro > drm/panel-elida-kd35t133: Drop custom DSI write macro > drm/panel-boe-bf060y8m-aj0: Drop custom DSI write macro > drm/panel-novatek-nt35950: Drop custom DSI write macro > drm/panel-jdi-fhd-r63452: Drop custom DSI write macros > drm/panel-samsung-s6e88a0-ams452ef01: Drop custom DSI write macro > drm/panel-samsung-sofef00: Drop custom DSI write macro > drm/panel-sharp-ls060t1sx01: Drop custom DSI write macro > drm/panel-mantix-mlaf057we51: Drop custom DSI write macro > drm/panel-sony-tulip-truly-nt35521: Drop custom DSI write macro > drm/panel-xinpeng-xpp055c272: Drop custom DSI write macro > > .../drm/panel/panel-asus-z00t-tm5p5-n35596.c | 96 ++--- > .../gpu/drm/panel/panel-boe-bf060y8m-aj0.c | 28 +- > drivers/gpu/drm/panel/panel-elida-kd35t133.c | 34 +- > drivers/gpu/drm/panel/panel-jdi-fhd-r63452.c | 50 +-- > .../drm/panel/panel-leadtek-ltk050h3146w.c | 64 ++-- > .../gpu/drm/panel/panel-mantix-mlaf057we51.c | 24 +- > drivers/gpu/drm/panel/panel-novatek-nt35950.c | 14 +- > .../panel/panel-samsung-s6e88a0-ams452ef01.c | 24 +- > drivers/gpu/drm/panel/panel-samsung-sofef00.c | 24 +- > .../gpu/drm/panel/panel-sharp-ls060t1sx01.c | 19 +- > drivers/gpu/drm/panel/panel-sitronix-st7703.c | 83 ++--- > .../panel/panel-sony-tulip-truly-nt35521.c | 348 +++++++++--------- > .../gpu/drm/panel/panel-xinpeng-xpp055c272.c | 44 +-- > include/drm/drm_mipi_dsi.h | 16 + > 14 files changed, 374 insertions(+), 494 deletions(-) > > -- > 2.38.1