Re: [PATCH 1/2] drm/panel-edp: fix name for IVO product id 854b

[Abel Vesa <abel.vesa@linaro.org>]

On 23-01-02 09:21:40, Johan Hovold wrote:
> On Sun, Jan 01, 2023 at 10:58:42PM -0600, Steev Klimaszewski wrote:
> > On Sat, Dec 31, 2022 at 8:27 AM Abel Vesa <abel.vesa@linaro.org> wrote:
> > >
> > > The actual name is R133NW4K-R0.
> > >
> > > Fixes: 0f9fa5f58c784 ("drm/panel-edp: add IVO M133NW4J-R3 panel entry")
> > > Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> > > ---
> > >
> > > Assuming the information from here is correct:
> > > https://raw.githubusercontent.com/linuxhw/EDID/master/DigitalDisplay.md
> > >
> > >  drivers/gpu/drm/panel/panel-edp.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c
> > > index 5cb8dc2ebe18..ef70928c3ccb 100644
> > > --- a/drivers/gpu/drm/panel/panel-edp.c
> > > +++ b/drivers/gpu/drm/panel/panel-edp.c
> > > @@ -1891,7 +1891,7 @@ static const struct edp_panel_entry edp_panels[] = {
> > >         EDP_PANEL_ENTRY('C', 'M', 'N', 0x1247, &delay_200_500_e80_d50, "N120ACA-EA1"),
> > >
> > >         EDP_PANEL_ENTRY('I', 'V', 'O', 0x057d, &delay_200_500_e200, "R140NWF5 RH"),
> > > -       EDP_PANEL_ENTRY('I', 'V', 'O', 0x854b, &delay_200_500_p2e100, "M133NW4J-R3"),
> > > +       EDP_PANEL_ENTRY('I', 'V', 'O', 0x854b, &delay_200_500_p2e100, "R133NW4K-R0"),
> > >
> > >         EDP_PANEL_ENTRY('K', 'D', 'B', 0x0624, &kingdisplay_kd116n21_30nv_a010.delay, "116N21-30NV-A010"),
> > >         EDP_PANEL_ENTRY('K', 'D', 'B', 0x1120, &delay_200_500_e80_d50, "116N29-30NK-C007"),
> > > --
> > > 2.34.1
> > >
> > 
> > Thanks for this - when I was looking for the panel, I simply went with
> > what I found on panel-look.
> 
> Did you check what string your panel reports? For example, using
> something like:
> 
> 	# strings /sys/class/drm/card0-eDP-1/edid
> 	...
> 	B133UAN02.1

Mine shows: M133NW4J R3

But since both R0 and R3 have the same product ID, I decided to drop the
revision part, otherwise we would need to add a second entry with the
only difference between them being the revision part (Rx). This is what
I did in patch #2.

> 
> Johan