From: Johan Hovold <johan@kernel.org>
To: Abel Vesa <abel.vesa@linaro.org>
Cc: Steev Klimaszewski <steev@kali.org>,
Douglas Anderson <dianders@chromium.org>,
Thierry Reding <thierry.reding@gmail.com>,
Sam Ravnborg <sam@ravnborg.org>, David Airlie <airlied@gmail.com>,
Daniel Vetter <daniel@ffwll.ch>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] drm/panel-edp: fix name for IVO product id 854b
Date: Tue, 3 Jan 2023 08:58:29 +0100 [thread overview]
Message-ID: <Y7PgJZtXBD42EobX@hovoldconsulting.com> (raw)
In-Reply-To: <Y7Ncg9DMbHBagcoz@linaro.org>
On Tue, Jan 03, 2023 at 12:36:51AM +0200, Abel Vesa wrote:
> On 23-01-02 09:21:40, Johan Hovold wrote:
> > On Sun, Jan 01, 2023 at 10:58:42PM -0600, Steev Klimaszewski wrote:
> > > On Sat, Dec 31, 2022 at 8:27 AM Abel Vesa <abel.vesa@linaro.org> wrote:
> > > >
> > > > The actual name is R133NW4K-R0.
> > > >
> > > > Fixes: 0f9fa5f58c784 ("drm/panel-edp: add IVO M133NW4J-R3 panel entry")
> > > > Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> > > > ---
> > > >
> > > > Assuming the information from here is correct:
> > > > https://raw.githubusercontent.com/linuxhw/EDID/master/DigitalDisplay.md
> > > Thanks for this - when I was looking for the panel, I simply went with
> > > what I found on panel-look.
> >
> > Did you check what string your panel reports? For example, using
> > something like:
> >
> > # strings /sys/class/drm/card0-eDP-1/edid
> > ...
> > B133UAN02.1
>
> Mine shows: M133NW4J R3
>
> But since both R0 and R3 have the same product ID, I decided to drop the
> revision part, otherwise we would need to add a second entry with the
> only difference between them being the revision part (Rx). This is what
> I did in patch #2.
Makes sense. Thanks for confirming.
Johan
next prev parent reply other threads:[~2023-01-03 7:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-31 14:27 [PATCH 1/2] drm/panel-edp: fix name for IVO product id 854b Abel Vesa
2022-12-31 14:27 ` [PATCH 2/2] drm/panel-edp: add IVO M133NW4J panel entry Abel Vesa
2023-01-02 8:27 ` Johan Hovold
2023-01-03 8:13 ` Johan Hovold
2023-01-11 0:59 ` Doug Anderson
2023-01-02 4:58 ` [PATCH 1/2] drm/panel-edp: fix name for IVO product id 854b Steev Klimaszewski
2023-01-02 8:21 ` Johan Hovold
2023-01-02 14:58 ` Steev Klimaszewski
2023-01-02 22:36 ` Abel Vesa
2023-01-03 7:58 ` Johan Hovold [this message]
2023-01-03 8:00 ` Johan Hovold
2023-01-11 0:57 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y7PgJZtXBD42EobX@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=abel.vesa@linaro.org \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=steev@kali.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox