* [PATCH 2/2] drm/panel-edp: add IVO M133NW4J panel entry
2022-12-31 14:27 [PATCH 1/2] drm/panel-edp: fix name for IVO product id 854b Abel Vesa
@ 2022-12-31 14:27 ` Abel Vesa
2023-01-02 8:27 ` Johan Hovold
` (2 more replies)
2023-01-02 4:58 ` [PATCH 1/2] drm/panel-edp: fix name for IVO product id 854b Steev Klimaszewski
` (2 subsequent siblings)
3 siblings, 3 replies; 12+ messages in thread
From: Abel Vesa @ 2022-12-31 14:27 UTC (permalink / raw)
To: Douglas Anderson, Thierry Reding, Sam Ravnborg, David Airlie,
Daniel Vetter, Steev Klimaszewski
Cc: dri-devel, linux-kernel, Johan Hovold
Add an eDP panel entry for IVO M133NW4J.
Due to lack of documentation, use the delay_200_500_p2e100 timings like
some other IVO entries for now.
Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
---
Assuming the information from here is correct:
https://raw.githubusercontent.com/linuxhw/EDID/master/DigitalDisplay.md
This fixes the following WARN_ON on my X13s:
[ 2.194973] CPU: 5 PID: 186 Comm: kworker/u16:6 Not tainted 6.2.0-rc1-00075-g5136d9aa278f-dirty #26
[ 2.195409] Hardware name: LENOVO 21BX000WRI/21BX000WRI, BIOS N3HET44W (1.16 ) 05/27/2022
[ 2.195820] Workqueue: events_unbound deferred_probe_work_func
[ 2.196234] pstate: 80400005 (Nzcv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--)
[ 2.196639] pc : panel_edp_probe+0x3d4/0x520 [panel_edp]
[ 2.197036] lr : panel_edp_probe+0x37c/0x520 [panel_edp]
[ 2.197435] sp : ffff80000970b3b0
[ 2.197833] x29: ffff80000970b3b0 x28: ffff0e0a80b7f760 x27: 0000000000000001
[ 2.198231] x26: ffff0e11fe0e1b50 x25: ffffa8f9f585e0c8 x24: 0000000000000000
[ 2.198630] x23: ffff0e0a81a39c80 x22: ffffa8f9f58c7638 x21: 0000000000000000
[ 2.199032] x20: ffff0e0a8d1b0000 x19: ffff0e0a820fea80 x18: 0000000000000000
[ 2.199576] x17: 0000000000000000 x16: ffffa8fa5e097080 x15: 0000000000000000
[ 2.199969] x14: 0000000000000003 x13: 0000000000000059 x12: 0000000000000066
[ 2.200360] x11: 0000000000000001 x10: 00000000000009e0 x9 : 0000000000000001
[ 2.200748] x8 : ffff80000970b340 x7 : 0000000000000000 x6 : 0000000000000000
[ 2.201132] x5 : 0000000000000049 x4 : 0000000000000056 x3 : 000000000000004f
[ 2.201512] x2 : 0000000000000000 x1 : ffffa8f9f58c7a00 x0 : 000000000000854a
[ 2.201888] Call trace:
[ 2.202261] panel_edp_probe+0x3d4/0x520 [panel_edp]
[ 2.202636] panel_edp_dp_aux_ep_probe+0x38/0x50 [panel_edp]
[ 2.203009] dp_aux_ep_probe+0x34/0xf4 [drm_dp_aux_bus]
[ 2.203379] really_probe+0xc0/0x3dc
[ 2.203739] __driver_probe_device+0x7c/0x190
[ 2.204096] driver_probe_device+0x3c/0x110
[ 2.204448] __device_attach_driver+0xbc/0x160
[ 2.204795] bus_for_each_drv+0x7c/0xd4
[ 2.205136] __device_attach+0x9c/0x1c0
[ 2.205439] device_initial_probe+0x14/0x20
[ 2.205717] bus_probe_device+0x9c/0xa4
[ 2.205995] device_add+0x3c4/0x8cc
[ 2.206270] device_register+0x20/0x30
[ 2.206543] of_dp_aux_populate_bus+0xe0/0x1bc [drm_dp_aux_bus]
[ 2.206817] msm_dp_modeset_init+0x1d8/0x274 [msm]
[ 2.207096] _dpu_kms_drm_obj_init+0x128/0x670 [msm]
[ 2.207370] dpu_kms_hw_init+0x540/0x640 [msm]
[ 2.207645] msm_drm_bind+0x18c/0x61c [msm]
[ 2.207917] try_to_bring_up_aggregate_device+0x1dc/0x2d0
[ 2.208186] __component_add+0xa4/0x190
[ 2.208454] component_add+0x14/0x20
[ 2.208720] dp_display_probe+0x29c/0x454 [msm]
[ 2.208989] platform_probe+0x68/0xc0
[ 2.209252] really_probe+0xc0/0x3dc
[ 2.209511] __driver_probe_device+0x7c/0x190
[ 2.209767] driver_probe_device+0x3c/0x110
[ 2.210022] __device_attach_driver+0xbc/0x160
[ 2.210275] bus_for_each_drv+0x7c/0xd4
[ 2.210528] __device_attach+0x9c/0x1c0
[ 2.210781] device_initial_probe+0x14/0x20
[ 2.211032] bus_probe_device+0x9c/0xa4
[ 2.211280] deferred_probe_work_func+0x9c/0xf0
[ 2.211525] process_one_work+0x1c4/0x320
[ 2.211768] worker_thread+0x6c/0x430
[ 2.212012] kthread+0x108/0x10c
[ 2.212251] ret_from_fork+0x10/0x20
[ 2.212488] ---[ end trace 0000000000000000 ]---
[ 2.212755] panel-simple-dp-aux aux-aea0000.displayport-controller: Unknown panel IVO 0x854a, using conservative timings
drivers/gpu/drm/panel/panel-edp.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c
index ef70928c3ccb..bef5cdf6a582 100644
--- a/drivers/gpu/drm/panel/panel-edp.c
+++ b/drivers/gpu/drm/panel/panel-edp.c
@@ -1891,6 +1891,7 @@ static const struct edp_panel_entry edp_panels[] = {
EDP_PANEL_ENTRY('C', 'M', 'N', 0x1247, &delay_200_500_e80_d50, "N120ACA-EA1"),
EDP_PANEL_ENTRY('I', 'V', 'O', 0x057d, &delay_200_500_e200, "R140NWF5 RH"),
+ EDP_PANEL_ENTRY('I', 'V', 'O', 0x854a, &delay_200_500_p2e100, "M133NW4J"),
EDP_PANEL_ENTRY('I', 'V', 'O', 0x854b, &delay_200_500_p2e100, "R133NW4K-R0"),
EDP_PANEL_ENTRY('K', 'D', 'B', 0x0624, &kingdisplay_kd116n21_30nv_a010.delay, "116N21-30NV-A010"),
--
2.34.1
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH 2/2] drm/panel-edp: add IVO M133NW4J panel entry
2022-12-31 14:27 ` [PATCH 2/2] drm/panel-edp: add IVO M133NW4J panel entry Abel Vesa
@ 2023-01-02 8:27 ` Johan Hovold
2023-01-03 8:13 ` Johan Hovold
2023-01-11 0:59 ` Doug Anderson
2 siblings, 0 replies; 12+ messages in thread
From: Johan Hovold @ 2023-01-02 8:27 UTC (permalink / raw)
To: Abel Vesa
Cc: Douglas Anderson, Thierry Reding, Sam Ravnborg, David Airlie,
Daniel Vetter, Steev Klimaszewski, dri-devel, linux-kernel
On Sat, Dec 31, 2022 at 04:27:21PM +0200, Abel Vesa wrote:
> Add an eDP panel entry for IVO M133NW4J.
>
> Due to lack of documentation, use the delay_200_500_p2e100 timings like
> some other IVO entries for now.
>
> Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> ---
>
> Assuming the information from here is correct:
> https://raw.githubusercontent.com/linuxhw/EDID/master/DigitalDisplay.md
> drivers/gpu/drm/panel/panel-edp.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c
> index ef70928c3ccb..bef5cdf6a582 100644
> --- a/drivers/gpu/drm/panel/panel-edp.c
> +++ b/drivers/gpu/drm/panel/panel-edp.c
> @@ -1891,6 +1891,7 @@ static const struct edp_panel_entry edp_panels[] = {
> EDP_PANEL_ENTRY('C', 'M', 'N', 0x1247, &delay_200_500_e80_d50, "N120ACA-EA1"),
>
> EDP_PANEL_ENTRY('I', 'V', 'O', 0x057d, &delay_200_500_e200, "R140NWF5 RH"),
> + EDP_PANEL_ENTRY('I', 'V', 'O', 0x854a, &delay_200_500_p2e100, "M133NW4J"),
> EDP_PANEL_ENTRY('I', 'V', 'O', 0x854b, &delay_200_500_p2e100, "R133NW4K-R0"),
>
> EDP_PANEL_ENTRY('K', 'D', 'B', 0x0624, &kingdisplay_kd116n21_30nv_a010.delay, "116N21-30NV-A010"),
Can you also check the edid data for the string in case there's been
some mixup? For example,
# strings /sys/class/drm/card0-eDP-1/edid
...
B133UAN02.1
Johan
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH 2/2] drm/panel-edp: add IVO M133NW4J panel entry
2022-12-31 14:27 ` [PATCH 2/2] drm/panel-edp: add IVO M133NW4J panel entry Abel Vesa
2023-01-02 8:27 ` Johan Hovold
@ 2023-01-03 8:13 ` Johan Hovold
2023-01-11 0:59 ` Doug Anderson
2 siblings, 0 replies; 12+ messages in thread
From: Johan Hovold @ 2023-01-03 8:13 UTC (permalink / raw)
To: Abel Vesa
Cc: Douglas Anderson, Thierry Reding, Sam Ravnborg, David Airlie,
Daniel Vetter, Steev Klimaszewski, dri-devel, linux-kernel
On Sat, Dec 31, 2022 at 04:27:21PM +0200, Abel Vesa wrote:
> Add an eDP panel entry for IVO M133NW4J.
>
> Due to lack of documentation, use the delay_200_500_p2e100 timings like
> some other IVO entries for now.
>
> Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> ---
Reviewed-by: Johan Hovold <johan+linaro@kernel.org>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 2/2] drm/panel-edp: add IVO M133NW4J panel entry
2022-12-31 14:27 ` [PATCH 2/2] drm/panel-edp: add IVO M133NW4J panel entry Abel Vesa
2023-01-02 8:27 ` Johan Hovold
2023-01-03 8:13 ` Johan Hovold
@ 2023-01-11 0:59 ` Doug Anderson
2 siblings, 0 replies; 12+ messages in thread
From: Doug Anderson @ 2023-01-11 0:59 UTC (permalink / raw)
To: Abel Vesa
Cc: Thierry Reding, Sam Ravnborg, David Airlie, Daniel Vetter,
Steev Klimaszewski, dri-devel, linux-kernel, Johan Hovold
Hi,
On Sat, Dec 31, 2022 at 6:27 AM Abel Vesa <abel.vesa@linaro.org> wrote:
>
> Add an eDP panel entry for IVO M133NW4J.
>
> Due to lack of documentation, use the delay_200_500_p2e100 timings like
> some other IVO entries for now.
>
> Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> ---
>
> Assuming the information from here is correct:
> https://raw.githubusercontent.com/linuxhw/EDID/master/DigitalDisplay.md
>
> This fixes the following WARN_ON on my X13s:
>
> [ 2.194973] CPU: 5 PID: 186 Comm: kworker/u16:6 Not tainted 6.2.0-rc1-00075-g5136d9aa278f-dirty #26
> [ 2.195409] Hardware name: LENOVO 21BX000WRI/21BX000WRI, BIOS N3HET44W (1.16 ) 05/27/2022
> [ 2.195820] Workqueue: events_unbound deferred_probe_work_func
> [ 2.196234] pstate: 80400005 (Nzcv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--)
> [ 2.196639] pc : panel_edp_probe+0x3d4/0x520 [panel_edp]
> [ 2.197036] lr : panel_edp_probe+0x37c/0x520 [panel_edp]
> [ 2.197435] sp : ffff80000970b3b0
> [ 2.197833] x29: ffff80000970b3b0 x28: ffff0e0a80b7f760 x27: 0000000000000001
> [ 2.198231] x26: ffff0e11fe0e1b50 x25: ffffa8f9f585e0c8 x24: 0000000000000000
> [ 2.198630] x23: ffff0e0a81a39c80 x22: ffffa8f9f58c7638 x21: 0000000000000000
> [ 2.199032] x20: ffff0e0a8d1b0000 x19: ffff0e0a820fea80 x18: 0000000000000000
> [ 2.199576] x17: 0000000000000000 x16: ffffa8fa5e097080 x15: 0000000000000000
> [ 2.199969] x14: 0000000000000003 x13: 0000000000000059 x12: 0000000000000066
> [ 2.200360] x11: 0000000000000001 x10: 00000000000009e0 x9 : 0000000000000001
> [ 2.200748] x8 : ffff80000970b340 x7 : 0000000000000000 x6 : 0000000000000000
> [ 2.201132] x5 : 0000000000000049 x4 : 0000000000000056 x3 : 000000000000004f
> [ 2.201512] x2 : 0000000000000000 x1 : ffffa8f9f58c7a00 x0 : 000000000000854a
> [ 2.201888] Call trace:
> [ 2.202261] panel_edp_probe+0x3d4/0x520 [panel_edp]
> [ 2.202636] panel_edp_dp_aux_ep_probe+0x38/0x50 [panel_edp]
> [ 2.203009] dp_aux_ep_probe+0x34/0xf4 [drm_dp_aux_bus]
> [ 2.203379] really_probe+0xc0/0x3dc
> [ 2.203739] __driver_probe_device+0x7c/0x190
> [ 2.204096] driver_probe_device+0x3c/0x110
> [ 2.204448] __device_attach_driver+0xbc/0x160
> [ 2.204795] bus_for_each_drv+0x7c/0xd4
> [ 2.205136] __device_attach+0x9c/0x1c0
> [ 2.205439] device_initial_probe+0x14/0x20
> [ 2.205717] bus_probe_device+0x9c/0xa4
> [ 2.205995] device_add+0x3c4/0x8cc
> [ 2.206270] device_register+0x20/0x30
> [ 2.206543] of_dp_aux_populate_bus+0xe0/0x1bc [drm_dp_aux_bus]
> [ 2.206817] msm_dp_modeset_init+0x1d8/0x274 [msm]
> [ 2.207096] _dpu_kms_drm_obj_init+0x128/0x670 [msm]
> [ 2.207370] dpu_kms_hw_init+0x540/0x640 [msm]
> [ 2.207645] msm_drm_bind+0x18c/0x61c [msm]
> [ 2.207917] try_to_bring_up_aggregate_device+0x1dc/0x2d0
> [ 2.208186] __component_add+0xa4/0x190
> [ 2.208454] component_add+0x14/0x20
> [ 2.208720] dp_display_probe+0x29c/0x454 [msm]
> [ 2.208989] platform_probe+0x68/0xc0
> [ 2.209252] really_probe+0xc0/0x3dc
> [ 2.209511] __driver_probe_device+0x7c/0x190
> [ 2.209767] driver_probe_device+0x3c/0x110
> [ 2.210022] __device_attach_driver+0xbc/0x160
> [ 2.210275] bus_for_each_drv+0x7c/0xd4
> [ 2.210528] __device_attach+0x9c/0x1c0
> [ 2.210781] device_initial_probe+0x14/0x20
> [ 2.211032] bus_probe_device+0x9c/0xa4
> [ 2.211280] deferred_probe_work_func+0x9c/0xf0
> [ 2.211525] process_one_work+0x1c4/0x320
> [ 2.211768] worker_thread+0x6c/0x430
> [ 2.212012] kthread+0x108/0x10c
> [ 2.212251] ret_from_fork+0x10/0x20
> [ 2.212488] ---[ end trace 0000000000000000 ]---
> [ 2.212755] panel-simple-dp-aux aux-aea0000.displayport-controller: Unknown panel IVO 0x854a, using conservative timings
>
> drivers/gpu/drm/panel/panel-edp.c | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Pushed to drm-misc-next:
e22391454e3e drm/panel-edp: add IVO M133NW4J panel entry
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] drm/panel-edp: fix name for IVO product id 854b
2022-12-31 14:27 [PATCH 1/2] drm/panel-edp: fix name for IVO product id 854b Abel Vesa
2022-12-31 14:27 ` [PATCH 2/2] drm/panel-edp: add IVO M133NW4J panel entry Abel Vesa
@ 2023-01-02 4:58 ` Steev Klimaszewski
2023-01-02 8:21 ` Johan Hovold
2023-01-03 8:00 ` Johan Hovold
2023-01-11 0:57 ` Doug Anderson
3 siblings, 1 reply; 12+ messages in thread
From: Steev Klimaszewski @ 2023-01-02 4:58 UTC (permalink / raw)
To: Abel Vesa
Cc: Douglas Anderson, Thierry Reding, Sam Ravnborg, David Airlie,
Daniel Vetter, dri-devel, linux-kernel, Johan Hovold
On Sat, Dec 31, 2022 at 8:27 AM Abel Vesa <abel.vesa@linaro.org> wrote:
>
> The actual name is R133NW4K-R0.
>
> Fixes: 0f9fa5f58c784 ("drm/panel-edp: add IVO M133NW4J-R3 panel entry")
> Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> ---
>
> Assuming the information from here is correct:
> https://raw.githubusercontent.com/linuxhw/EDID/master/DigitalDisplay.md
>
> drivers/gpu/drm/panel/panel-edp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c
> index 5cb8dc2ebe18..ef70928c3ccb 100644
> --- a/drivers/gpu/drm/panel/panel-edp.c
> +++ b/drivers/gpu/drm/panel/panel-edp.c
> @@ -1891,7 +1891,7 @@ static const struct edp_panel_entry edp_panels[] = {
> EDP_PANEL_ENTRY('C', 'M', 'N', 0x1247, &delay_200_500_e80_d50, "N120ACA-EA1"),
>
> EDP_PANEL_ENTRY('I', 'V', 'O', 0x057d, &delay_200_500_e200, "R140NWF5 RH"),
> - EDP_PANEL_ENTRY('I', 'V', 'O', 0x854b, &delay_200_500_p2e100, "M133NW4J-R3"),
> + EDP_PANEL_ENTRY('I', 'V', 'O', 0x854b, &delay_200_500_p2e100, "R133NW4K-R0"),
>
> EDP_PANEL_ENTRY('K', 'D', 'B', 0x0624, &kingdisplay_kd116n21_30nv_a010.delay, "116N21-30NV-A010"),
> EDP_PANEL_ENTRY('K', 'D', 'B', 0x1120, &delay_200_500_e80_d50, "116N29-30NK-C007"),
> --
> 2.34.1
>
Thanks for this - when I was looking for the panel, I simply went with
what I found on panel-look.
Tested-by: Steev Klimaszewski <steev@kali.org>
--steev
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH 1/2] drm/panel-edp: fix name for IVO product id 854b
2023-01-02 4:58 ` [PATCH 1/2] drm/panel-edp: fix name for IVO product id 854b Steev Klimaszewski
@ 2023-01-02 8:21 ` Johan Hovold
2023-01-02 14:58 ` Steev Klimaszewski
2023-01-02 22:36 ` Abel Vesa
0 siblings, 2 replies; 12+ messages in thread
From: Johan Hovold @ 2023-01-02 8:21 UTC (permalink / raw)
To: Steev Klimaszewski
Cc: Abel Vesa, Douglas Anderson, Thierry Reding, Sam Ravnborg,
David Airlie, Daniel Vetter, dri-devel, linux-kernel
On Sun, Jan 01, 2023 at 10:58:42PM -0600, Steev Klimaszewski wrote:
> On Sat, Dec 31, 2022 at 8:27 AM Abel Vesa <abel.vesa@linaro.org> wrote:
> >
> > The actual name is R133NW4K-R0.
> >
> > Fixes: 0f9fa5f58c784 ("drm/panel-edp: add IVO M133NW4J-R3 panel entry")
> > Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> > ---
> >
> > Assuming the information from here is correct:
> > https://raw.githubusercontent.com/linuxhw/EDID/master/DigitalDisplay.md
> >
> > drivers/gpu/drm/panel/panel-edp.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c
> > index 5cb8dc2ebe18..ef70928c3ccb 100644
> > --- a/drivers/gpu/drm/panel/panel-edp.c
> > +++ b/drivers/gpu/drm/panel/panel-edp.c
> > @@ -1891,7 +1891,7 @@ static const struct edp_panel_entry edp_panels[] = {
> > EDP_PANEL_ENTRY('C', 'M', 'N', 0x1247, &delay_200_500_e80_d50, "N120ACA-EA1"),
> >
> > EDP_PANEL_ENTRY('I', 'V', 'O', 0x057d, &delay_200_500_e200, "R140NWF5 RH"),
> > - EDP_PANEL_ENTRY('I', 'V', 'O', 0x854b, &delay_200_500_p2e100, "M133NW4J-R3"),
> > + EDP_PANEL_ENTRY('I', 'V', 'O', 0x854b, &delay_200_500_p2e100, "R133NW4K-R0"),
> >
> > EDP_PANEL_ENTRY('K', 'D', 'B', 0x0624, &kingdisplay_kd116n21_30nv_a010.delay, "116N21-30NV-A010"),
> > EDP_PANEL_ENTRY('K', 'D', 'B', 0x1120, &delay_200_500_e80_d50, "116N29-30NK-C007"),
> > --
> > 2.34.1
> >
>
> Thanks for this - when I was looking for the panel, I simply went with
> what I found on panel-look.
Did you check what string your panel reports? For example, using
something like:
# strings /sys/class/drm/card0-eDP-1/edid
...
B133UAN02.1
Johan
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH 1/2] drm/panel-edp: fix name for IVO product id 854b
2023-01-02 8:21 ` Johan Hovold
@ 2023-01-02 14:58 ` Steev Klimaszewski
2023-01-02 22:36 ` Abel Vesa
1 sibling, 0 replies; 12+ messages in thread
From: Steev Klimaszewski @ 2023-01-02 14:58 UTC (permalink / raw)
To: Johan Hovold
Cc: Abel Vesa, Douglas Anderson, Thierry Reding, Sam Ravnborg,
David Airlie, Daniel Vetter, dri-devel, linux-kernel
On 1/2/23 2:21 AM, Johan Hovold wrote:
> On Sun, Jan 01, 2023 at 10:58:42PM -0600, Steev Klimaszewski wrote:
>> On Sat, Dec 31, 2022 at 8:27 AM Abel Vesa <abel.vesa@linaro.org> wrote:
>>> The actual name is R133NW4K-R0.
>>>
>>> Fixes: 0f9fa5f58c784 ("drm/panel-edp: add IVO M133NW4J-R3 panel entry")
>>> Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
>>> ---
>>>
>>> Assuming the information from here is correct:
>>> https://raw.githubusercontent.com/linuxhw/EDID/master/DigitalDisplay.md
>>>
>>> drivers/gpu/drm/panel/panel-edp.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c
>>> index 5cb8dc2ebe18..ef70928c3ccb 100644
>>> --- a/drivers/gpu/drm/panel/panel-edp.c
>>> +++ b/drivers/gpu/drm/panel/panel-edp.c
>>> @@ -1891,7 +1891,7 @@ static const struct edp_panel_entry edp_panels[] = {
>>> EDP_PANEL_ENTRY('C', 'M', 'N', 0x1247, &delay_200_500_e80_d50, "N120ACA-EA1"),
>>>
>>> EDP_PANEL_ENTRY('I', 'V', 'O', 0x057d, &delay_200_500_e200, "R140NWF5 RH"),
>>> - EDP_PANEL_ENTRY('I', 'V', 'O', 0x854b, &delay_200_500_p2e100, "M133NW4J-R3"),
>>> + EDP_PANEL_ENTRY('I', 'V', 'O', 0x854b, &delay_200_500_p2e100, "R133NW4K-R0"),
>>>
>>> EDP_PANEL_ENTRY('K', 'D', 'B', 0x0624, &kingdisplay_kd116n21_30nv_a010.delay, "116N21-30NV-A010"),
>>> EDP_PANEL_ENTRY('K', 'D', 'B', 0x1120, &delay_200_500_e80_d50, "116N29-30NK-C007"),
>>> --
>>> 2.34.1
>>>
>> Thanks for this - when I was looking for the panel, I simply went with
>> what I found on panel-look.
> Did you check what string your panel reports? For example, using
> something like:
>
> # strings /sys/class/drm/card0-eDP-1/edid
> ...
> B133UAN02.1
>
> Johan
Hi Johan,
At the time, I did not, and I do not know why I didn't.
I am showing
"R133NW4K R0"
-- steev
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH 1/2] drm/panel-edp: fix name for IVO product id 854b
2023-01-02 8:21 ` Johan Hovold
2023-01-02 14:58 ` Steev Klimaszewski
@ 2023-01-02 22:36 ` Abel Vesa
2023-01-03 7:58 ` Johan Hovold
1 sibling, 1 reply; 12+ messages in thread
From: Abel Vesa @ 2023-01-02 22:36 UTC (permalink / raw)
To: Johan Hovold
Cc: Steev Klimaszewski, Douglas Anderson, Thierry Reding,
Sam Ravnborg, David Airlie, Daniel Vetter, dri-devel,
linux-kernel
On 23-01-02 09:21:40, Johan Hovold wrote:
> On Sun, Jan 01, 2023 at 10:58:42PM -0600, Steev Klimaszewski wrote:
> > On Sat, Dec 31, 2022 at 8:27 AM Abel Vesa <abel.vesa@linaro.org> wrote:
> > >
> > > The actual name is R133NW4K-R0.
> > >
> > > Fixes: 0f9fa5f58c784 ("drm/panel-edp: add IVO M133NW4J-R3 panel entry")
> > > Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> > > ---
> > >
> > > Assuming the information from here is correct:
> > > https://raw.githubusercontent.com/linuxhw/EDID/master/DigitalDisplay.md
> > >
> > > drivers/gpu/drm/panel/panel-edp.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c
> > > index 5cb8dc2ebe18..ef70928c3ccb 100644
> > > --- a/drivers/gpu/drm/panel/panel-edp.c
> > > +++ b/drivers/gpu/drm/panel/panel-edp.c
> > > @@ -1891,7 +1891,7 @@ static const struct edp_panel_entry edp_panels[] = {
> > > EDP_PANEL_ENTRY('C', 'M', 'N', 0x1247, &delay_200_500_e80_d50, "N120ACA-EA1"),
> > >
> > > EDP_PANEL_ENTRY('I', 'V', 'O', 0x057d, &delay_200_500_e200, "R140NWF5 RH"),
> > > - EDP_PANEL_ENTRY('I', 'V', 'O', 0x854b, &delay_200_500_p2e100, "M133NW4J-R3"),
> > > + EDP_PANEL_ENTRY('I', 'V', 'O', 0x854b, &delay_200_500_p2e100, "R133NW4K-R0"),
> > >
> > > EDP_PANEL_ENTRY('K', 'D', 'B', 0x0624, &kingdisplay_kd116n21_30nv_a010.delay, "116N21-30NV-A010"),
> > > EDP_PANEL_ENTRY('K', 'D', 'B', 0x1120, &delay_200_500_e80_d50, "116N29-30NK-C007"),
> > > --
> > > 2.34.1
> > >
> >
> > Thanks for this - when I was looking for the panel, I simply went with
> > what I found on panel-look.
>
> Did you check what string your panel reports? For example, using
> something like:
>
> # strings /sys/class/drm/card0-eDP-1/edid
> ...
> B133UAN02.1
Mine shows: M133NW4J R3
But since both R0 and R3 have the same product ID, I decided to drop the
revision part, otherwise we would need to add a second entry with the
only difference between them being the revision part (Rx). This is what
I did in patch #2.
>
> Johan
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH 1/2] drm/panel-edp: fix name for IVO product id 854b
2023-01-02 22:36 ` Abel Vesa
@ 2023-01-03 7:58 ` Johan Hovold
0 siblings, 0 replies; 12+ messages in thread
From: Johan Hovold @ 2023-01-03 7:58 UTC (permalink / raw)
To: Abel Vesa
Cc: Steev Klimaszewski, Douglas Anderson, Thierry Reding,
Sam Ravnborg, David Airlie, Daniel Vetter, dri-devel,
linux-kernel
On Tue, Jan 03, 2023 at 12:36:51AM +0200, Abel Vesa wrote:
> On 23-01-02 09:21:40, Johan Hovold wrote:
> > On Sun, Jan 01, 2023 at 10:58:42PM -0600, Steev Klimaszewski wrote:
> > > On Sat, Dec 31, 2022 at 8:27 AM Abel Vesa <abel.vesa@linaro.org> wrote:
> > > >
> > > > The actual name is R133NW4K-R0.
> > > >
> > > > Fixes: 0f9fa5f58c784 ("drm/panel-edp: add IVO M133NW4J-R3 panel entry")
> > > > Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> > > > ---
> > > >
> > > > Assuming the information from here is correct:
> > > > https://raw.githubusercontent.com/linuxhw/EDID/master/DigitalDisplay.md
> > > Thanks for this - when I was looking for the panel, I simply went with
> > > what I found on panel-look.
> >
> > Did you check what string your panel reports? For example, using
> > something like:
> >
> > # strings /sys/class/drm/card0-eDP-1/edid
> > ...
> > B133UAN02.1
>
> Mine shows: M133NW4J R3
>
> But since both R0 and R3 have the same product ID, I decided to drop the
> revision part, otherwise we would need to add a second entry with the
> only difference between them being the revision part (Rx). This is what
> I did in patch #2.
Makes sense. Thanks for confirming.
Johan
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] drm/panel-edp: fix name for IVO product id 854b
2022-12-31 14:27 [PATCH 1/2] drm/panel-edp: fix name for IVO product id 854b Abel Vesa
2022-12-31 14:27 ` [PATCH 2/2] drm/panel-edp: add IVO M133NW4J panel entry Abel Vesa
2023-01-02 4:58 ` [PATCH 1/2] drm/panel-edp: fix name for IVO product id 854b Steev Klimaszewski
@ 2023-01-03 8:00 ` Johan Hovold
2023-01-11 0:57 ` Doug Anderson
3 siblings, 0 replies; 12+ messages in thread
From: Johan Hovold @ 2023-01-03 8:00 UTC (permalink / raw)
To: Abel Vesa
Cc: Douglas Anderson, Thierry Reding, Sam Ravnborg, David Airlie,
Daniel Vetter, Steev Klimaszewski, dri-devel, linux-kernel
On Sat, Dec 31, 2022 at 04:27:20PM +0200, Abel Vesa wrote:
> The actual name is R133NW4K-R0.
>
> Fixes: 0f9fa5f58c784 ("drm/panel-edp: add IVO M133NW4J-R3 panel entry")
> Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
Reviewed-by: Johan Hovold <johan+linaro@kernel.org>
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH 1/2] drm/panel-edp: fix name for IVO product id 854b
2022-12-31 14:27 [PATCH 1/2] drm/panel-edp: fix name for IVO product id 854b Abel Vesa
` (2 preceding siblings ...)
2023-01-03 8:00 ` Johan Hovold
@ 2023-01-11 0:57 ` Doug Anderson
3 siblings, 0 replies; 12+ messages in thread
From: Doug Anderson @ 2023-01-11 0:57 UTC (permalink / raw)
To: Abel Vesa
Cc: Thierry Reding, Sam Ravnborg, David Airlie, Daniel Vetter,
Steev Klimaszewski, dri-devel, linux-kernel, Johan Hovold
Hi,
On Sat, Dec 31, 2022 at 6:27 AM Abel Vesa <abel.vesa@linaro.org> wrote:
>
> The actual name is R133NW4K-R0.
>
> Fixes: 0f9fa5f58c784 ("drm/panel-edp: add IVO M133NW4J-R3 panel entry")
-:8: WARNING:BAD_FIXES_TAG: Please use correct Fixes: style 'Fixes:
<12 chars of sha1> ("<title line>")' - ie: 'Fixes: 0f9fa5f58c78
("drm/panel-edp: add IVO M133NW4J-R3 panel entry")'
#8:
Fixes: 0f9fa5f58c784 ("drm/panel-edp: add IVO M133NW4J-R3 panel entry")
Essentially you have one too many hex digits. I'll fix it for you this
time, but please remember for the future.
> Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> ---
>
> Assuming the information from here is correct:
> https://raw.githubusercontent.com/linuxhw/EDID/master/DigitalDisplay.md
This is nifty--I wasn't aware of this database.
> drivers/gpu/drm/panel/panel-edp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Fixes: 0f9fa5f58c78 ("drm/panel-edp: add IVO M133NW4J-R3 panel entry")
Pushed to drm-misc-next. I didn't bother doing "drm-misc-fixes"
because it didn't seem urgent and it would have caused a merge
conflict with the next patch.
9cce08cadc6c drm/panel-edp: fix name for IVO product id 854b
-Doug
^ permalink raw reply [flat|nested] 12+ messages in thread