From: Heiko Carstens <hca@linux.ibm.com>
To: Sven Schnelle <svens@linux.ibm.com>
Cc: Willy Tarreau <w@1wt.eu>,
"Paul E . McKenney" <paulmck@kernel.org>,
Josh Triplett <josh@joshtriplett.org>,
Steven Rostedt <rostedt@goodmis.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Lai Jiangshan <jiangshanlai@gmail.com>,
linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org
Subject: Re: [PATCH v3 3/5] selftests/nolibc: add s390 support
Date: Tue, 3 Jan 2023 20:03:20 +0100 [thread overview]
Message-ID: <Y7R7+BIEvFdxMJIu@osiris> (raw)
In-Reply-To: <20230103071957.222360-4-svens@linux.ibm.com>
On Tue, Jan 03, 2023 at 08:19:55AM +0100, Sven Schnelle wrote:
> Signed-off-by: Sven Schnelle <svens@linux.ibm.com>
> Acked-by: Heiko Carstens <hca@linux.ibm.com>
> ---
> tools/testing/selftests/nolibc/Makefile | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
...
> -CFLAGS ?= -Os -fno-ident -fno-asynchronous-unwind-tables
> +CFLAGS_s390 = -m64
> +CFLAGS ?= -Os -fno-ident -fno-asynchronous-unwind-tables $(CFLAGS_$(ARCH))
Since this adds support for architecture specific compile flags, you
might as well want to add -march=z10, since that's the minimum
architecture level for the kernel we support anyway.
That way you won't end up with problems like the lay instruction, and
could also use cghsi for zero comparison. Not that I'm proposing that
you should change the asm code again, it is fine as it is now.
next prev parent reply other threads:[~2023-01-03 19:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-03 7:19 [PATCH v3 0/5] add s390 support to nolibc and rcutorture Sven Schnelle
2023-01-03 7:19 ` [PATCH v3 1/5] nolibc: fix fd_set type Sven Schnelle
2023-01-03 7:19 ` [PATCH v3 2/5] nolibc: add support for s390 Sven Schnelle
2023-01-03 7:19 ` [PATCH v3 3/5] selftests/nolibc: add s390 support Sven Schnelle
2023-01-03 19:03 ` Heiko Carstens [this message]
2023-01-03 7:19 ` [PATCH v3 4/5] rcutorture: add support for s390 Sven Schnelle
2023-01-03 7:19 ` [PATCH v3 5/5] rcutorture: build initrd for rcutorture with nolibc Sven Schnelle
2023-01-08 9:20 ` [PATCH v3 0/5] add s390 support to nolibc and rcutorture Willy Tarreau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y7R7+BIEvFdxMJIu@osiris \
--to=hca@linux.ibm.com \
--cc=jiangshanlai@gmail.com \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=paulmck@kernel.org \
--cc=rostedt@goodmis.org \
--cc=svens@linux.ibm.com \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox