public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg@nvidia.com>
To: Longfang Liu <liulongfang@huawei.com>
Cc: alex.williamson@redhat.com, shameerali.kolothum.thodi@huawei.com,
	jonathan.cameron@huawei.com, cohuck@redhat.com,
	linux-kernel@vger.kernel.org, linuxarm@openeuler.org
Subject: Re: [PATCH v5 3/5] hisi_acc_vfio_pci: register debugfs for hisilicon migration driver
Date: Tue, 3 Jan 2023 11:07:52 -0400	[thread overview]
Message-ID: <Y7REyEY2ngkHT6z+@nvidia.com> (raw)
In-Reply-To: <20221217063248.6735-4-liulongfang@huawei.com>

On Sat, Dec 17, 2022 at 02:32:46PM +0800, Longfang Liu wrote:
> On the debugfs framework of VFIO, register the debug function
> for the live migration driver of the hisilicon accelerator device.
> 
> On the basis of the original public debug function, a private debug
> function is added:
> 
> mig_data file: used to get the migration data of the live migration device
> mig_attr file: used to get device attributes of the live migration device
> debug file: used to test for acquiring and writing device state data
> for VF device.
> 
> Signed-off-by: Longfang Liu <liulongfang@huawei.com>
> ---
>  .../vfio/pci/hisilicon/hisi_acc_vfio_pci.c    | 276 ++++++++++++++++++
>  .../vfio/pci/hisilicon/hisi_acc_vfio_pci.h    |  11 +
>  2 files changed, 287 insertions(+)

You should put this all in its own file and not compile it when
debugfs is turned off as well.

Jason

  reply	other threads:[~2023-01-03 15:08 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-17  6:32 [PATCH v5 0/5] add debugfs to migration driver Longfang Liu
2022-12-17  6:32 ` [PATCH v5 1/5] vfio/migration: Add debugfs to live " Longfang Liu
2023-01-03 15:05   ` Jason Gunthorpe
2023-01-04  3:10     ` liulongfang
2022-12-17  6:32 ` [PATCH v5 2/5] hisi_acc_vfio_pci: extract public functions for container_of Longfang Liu
2022-12-17  6:32 ` [PATCH v5 3/5] hisi_acc_vfio_pci: register debugfs for hisilicon migration driver Longfang Liu
2023-01-03 15:07   ` Jason Gunthorpe [this message]
2023-01-04  3:20     ` liulongfang
2022-12-17  6:32 ` [PATCH v5 4/5] Documentation: add debugfs description for hisi_acc_vfio_pci Longfang Liu
2022-12-17  6:32 ` [PATCH v5 5/5] vfio: update live migration device status Longfang Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y7REyEY2ngkHT6z+@nvidia.com \
    --to=jgg@nvidia.com \
    --cc=alex.williamson@redhat.com \
    --cc=cohuck@redhat.com \
    --cc=jonathan.cameron@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxarm@openeuler.org \
    --cc=liulongfang@huawei.com \
    --cc=shameerali.kolothum.thodi@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox