From: "Darrick J. Wong" <djwong@kernel.org>
To: Li zeming <zeming@nfschina.com>
Cc: linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] xfs: xfs_qm: remove unnecessary ‘0’ values from error
Date: Tue, 3 Jan 2023 10:07:43 -0800 [thread overview]
Message-ID: <Y7Ru73JbumMnTEqc@magnolia> (raw)
In-Reply-To: <20221223081114.3959-1-zeming@nfschina.com>
On Fri, Dec 23, 2022 at 04:11:14PM +0800, Li zeming wrote:
> error is assigned first, so it does not need to initialize the
> assignment.
>
> Signed-off-by: Li zeming <zeming@nfschina.com>
Looks fine to me...
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
--D
> ---
> fs/xfs/xfs_qm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_qm.c b/fs/xfs/xfs_qm.c
> index ff53d40a2dae..e2c542f6dcd4 100644
> --- a/fs/xfs/xfs_qm.c
> +++ b/fs/xfs/xfs_qm.c
> @@ -68,7 +68,7 @@ xfs_qm_dquot_walk(
>
> while (1) {
> struct xfs_dquot *batch[XFS_DQ_LOOKUP_BATCH];
> - int error = 0;
> + int error;
> int i;
>
> mutex_lock(&qi->qi_tree_lock);
> --
> 2.18.2
>
prev parent reply other threads:[~2023-01-03 18:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-23 8:11 [PATCH] xfs: xfs_qm: remove unnecessary ‘0’ values from error Li zeming
2023-01-03 18:07 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y7Ru73JbumMnTEqc@magnolia \
--to=djwong@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=zeming@nfschina.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox