From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C1CDC4332F for ; Wed, 4 Jan 2023 11:48:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239124AbjADLsF (ORCPT ); Wed, 4 Jan 2023 06:48:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58224 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234726AbjADLsB (ORCPT ); Wed, 4 Jan 2023 06:48:01 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1D7BB1EAFD; Wed, 4 Jan 2023 03:48:01 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 94024613EA; Wed, 4 Jan 2023 11:48:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3B7DAC433D2; Wed, 4 Jan 2023 11:47:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1672832880; bh=tVKRtnWaZZzqrPq8yrMjFtLHPJFEtdjwVzN5HPz6PNo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZtdG5nNtzC4Qg4uKG4pKE1cjLnujfr11dKH4dcnGqbvdi4a63JcgSsCpcIolbLqvp nuE/yaN6zxt8gd27w1S0kdPYXv5sPHMMPawNOCuuIac4nGCNYSOfExWstXfTSfON2y z69JsG2uLaKs2Pz/gbf0p0dzPeFbrO90QW/7BwXgomngxCkpqb8sr77kriK0NYuhrz Bmcpe0tIa5KphOKZV3S/EC/TpQ7joEw0wte8zpgcRZ31HJGk3Tyfk++daz3FuPNHdI DlXszGvUQ/aoOxmjdxUe5qAcqVZqYLdze4wmMs8+P9bn7HcGT+c78ubPaOj+qAistf ksln38PZ5v5nQ== Date: Wed, 4 Jan 2023 13:47:55 +0200 From: Leon Romanovsky To: Jiasheng Jiang Cc: gregory.greenman@intel.com, kvalo@kernel.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, luciano.coelho@intel.com, johannes.berg@intel.com, shaul.triebitz@intel.com, linux-wireless@vger.kernel.or, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] iwlwifi: Add missing check for alloc_ordered_workqueue Message-ID: References: <20230104100059.24987-1-jiasheng@iscas.ac.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230104100059.24987-1-jiasheng@iscas.ac.cn> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 04, 2023 at 06:00:59PM +0800, Jiasheng Jiang wrote: > Add check for the return value of alloc_ordered_workqueue since it may > return NULL pointer. > > Fixes: b481de9ca074 ("[IWLWIFI]: add iwlwifi wireless drivers") > Signed-off-by: Jiasheng Jiang > --- > drivers/net/wireless/intel/iwlwifi/dvm/main.c | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > Thanks, Reviewed-by: Leon Romanovsky