From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 710C1C5479D for ; Wed, 4 Jan 2023 14:22:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239541AbjADOWI (ORCPT ); Wed, 4 Jan 2023 09:22:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46428 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239516AbjADOVz (ORCPT ); Wed, 4 Jan 2023 09:21:55 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1C41FAA; Wed, 4 Jan 2023 06:21:55 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id CD971B81674; Wed, 4 Jan 2023 14:21:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 65CDAC433D2; Wed, 4 Jan 2023 14:21:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1672842112; bh=S0pBAaBYAWYNmqrdaqt5KAjvTcU4XOUWLTxzTiYZlc0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=P7/+rbmx9zgpXDCY2DL8IiEBDNoJZQz8nHuPnLxP2v+Cr9Dbj8uxTnGewRb6SPMso KlyfTvck3sL5jLdaihFnx4EsmF5uAj7hOP2JoZ0MmxVlO/18ySgOT+goOPmJtIJq7j JGZ7O+SsY5Uqsz2ow1+FUmWnGGS5oo3bAwnQ6uS6duUsiCuR9TqKFbYCM2lIygqMoN B3I0JAfzNdnLvOkUtrSv3hPgA+JuTC7oUX+9kzm9lkqIi91EPaCBXV/MeTzka+qaPR KjDj8/i+A2U0FrPRQ8GwQeuzOhjnY76JP9MVzbE5EozR7RMofDm74uhC71MN9nw5G0 /Ku+8JEuL228A== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 71CA140468; Wed, 4 Jan 2023 11:21:50 -0300 (-03) Date: Wed, 4 Jan 2023 11:21:50 -0300 From: Arnaldo Carvalho de Melo To: Namhyung Kim Cc: Jiri Olsa , Ingo Molnar , Peter Zijlstra , LKML , Ian Rogers , Adrian Hunter , linux-perf-users@vger.kernel.org, Song Liu , bpf@vger.kernel.org Subject: Re: [PATCH 0/4] perf bpf_counter: A set of random fixes (v1) Message-ID: References: <20230104064402.1551516-1-namhyung@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230104064402.1551516-1-namhyung@kernel.org> X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Tue, Jan 03, 2023 at 10:43:58PM -0800, Namhyung Kim escreveu: > Hello, > > This is a collection of small fixes for perf stat bpf counters (bperf). > > The bperf framework maintains perf_attr_map in the BPF fs to share the > same event as much as possible. But the size was limited to 16 and > perf stat with -ddd option would create more than 16 events and fails. > > Also cgroup events with --for-each-cgroup had some other problems when > dealing with unsupported events and duplicate cgroups. > > The code is available at 'perf/stat-bpf-fix-v1' branch in > > git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git The first two are improvements, not strict fixes, so I'm leaving them for the next merge window. - Arnaldo > Thanks, > Namhyung > > Namhyung Kim (4): > perf bpf_counter: Add more error messages for bperf > perf bpf_counter: Increase perf_attr_map entries to 32 > perf bpf_counter: Handle unsupported cgroup events > perf stat: Do not use the same cgroup more than once > > tools/perf/util/bpf_counter.c | 11 ++++++++--- > tools/perf/util/bpf_counter_cgroup.c | 14 +++----------- > tools/perf/util/cgroup.c | 23 ++++++++++++++++++----- > 3 files changed, 29 insertions(+), 19 deletions(-) > > > base-commit: d8d85ce86dc82de4f88b821a78f533b9d5b22a45 > -- > 2.39.0.314.g84b9a713c41-goog -- - Arnaldo