From: Borislav Petkov <bp@alien8.de>
To: Ashok Raj <ashok.raj@intel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>, X86-kernel <x86@kernel.org>,
LKML Mailing List <linux-kernel@vger.kernel.org>,
Dave Hansen <dave.hansen@intel.com>,
Tony Luck <tony.luck@intel.com>,
Alison Schofield <alison.schofield@intel.com>,
Reinette Chatre <reinette.chatre@intel.com>,
Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [PATCH v3 1/6] x86/microcode: Add a parameter to microcode_check() to store CPU capabilities
Date: Wed, 4 Jan 2023 19:21:11 +0100 [thread overview]
Message-ID: <Y7XDlyHY2kFeMUMI@zn.tnic> (raw)
In-Reply-To: <20230103180212.333496-2-ashok.raj@intel.com>
On Tue, Jan 03, 2023 at 10:02:07AM -0800, Ashok Raj wrote:
> This is a preparation before the next patch uses this to compare CPU
Once a patch is in git, the concept of "subsequent" or "next" patch becomes
ambiguous depending on how you're sorting them.
So you should strive for your commit messages to make sense on their own,
without referencing other "subsequent" or "next" patches.
> capabilities after performing an update.
>
> Add a parameter to store CPU capabilities before performing a microcode
> update.
" ... so that code later can do X."
And that is enough for an explanation.
> diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c
> index 9cfca3d7d0e2..b9c7529c920e 100644
> --- a/arch/x86/kernel/cpu/common.c
> +++ b/arch/x86/kernel/cpu/common.c
> @@ -2302,25 +2302,23 @@ void cpu_init_secondary(void)
> * only when microcode has been updated. Caller holds microcode_mutex and CPU
> * hotplug lock.
<--- I guess you can document that new parameter here.
> */
> -void microcode_check(void)
> +void microcode_check(struct cpuinfo_x86 *info)
...
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2023-01-04 18:21 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-03 18:02 [PATCH v3 0/6] Some fixes and cleanups for microcode Ashok Raj
2023-01-03 18:02 ` [PATCH v3 1/6] x86/microcode: Add a parameter to microcode_check() to store CPU capabilities Ashok Raj
2023-01-04 18:21 ` Borislav Petkov [this message]
2023-01-03 18:02 ` [PATCH v3 2/6] x86/microcode/core: Take a snapshot before and after applying microcode Ashok Raj
2023-01-03 18:46 ` Dave Hansen
2023-01-03 19:37 ` Ashok Raj
2023-01-04 18:56 ` Borislav Petkov
2023-01-06 20:41 ` Ashok Raj
2023-01-03 18:02 ` [PATCH v3 3/6] x86/microcode: Display revisions only when update is successful Ashok Raj
2023-01-04 19:00 ` Borislav Petkov
2023-01-06 19:42 ` Ashok Raj
2023-01-06 19:54 ` Borislav Petkov
2023-01-06 20:29 ` Ashok Raj
2023-01-06 20:45 ` Borislav Petkov
2023-01-06 21:20 ` Ashok Raj
2023-01-07 9:36 ` Ingo Molnar
2023-01-06 21:35 ` Luck, Tony
2023-01-06 21:52 ` Borislav Petkov
2023-01-03 18:02 ` [PATCH v3 4/6] x86/microcode/intel: Use a plain revision argument for print_ucode_rev() Ashok Raj
2023-01-03 18:02 ` [PATCH v3 5/6] x86/microcode/intel: Print old and new rev during early boot Ashok Raj
2023-01-03 18:02 ` [PATCH v3 6/6] x86/microcode/intel: Print when early microcode loading fails Ashok Raj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y7XDlyHY2kFeMUMI@zn.tnic \
--to=bp@alien8.de \
--cc=alison.schofield@intel.com \
--cc=ashok.raj@intel.com \
--cc=dave.hansen@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=reinette.chatre@intel.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox