From: Sean Christopherson <seanjc@google.com>
To: David Woodhouse <dwmw2@infradead.org>
Cc: Paul Durrant <pdurrant@amazon.com>,
x86@kernel.org, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org, Paolo Bonzini <pbonzini@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH v6 2/2] KVM: x86/xen: update Xen CPUID Leaf 4 (tsc info) sub-leaves, if present
Date: Wed, 4 Jan 2023 20:20:55 +0000 [thread overview]
Message-ID: <Y7Xfp3Izlc6VPEzC@google.com> (raw)
In-Reply-To: <0e58d9a6bc8bf15c23feff25ec24e9b3c26945cc.camel@infradead.org>
On Wed, Jan 04, 2023, David Woodhouse wrote:
> On Wed, 2023-01-04 at 19:40 +0000, Sean Christopherson wrote:
> >
> > arch/x86/include/asm/xen/hypervisor.h also open codes the signature. Rather than
> > add a KVM-specific define, what about putting in xen/cpuid.h? (I've had a version
> > of this series sitting in my todo pile for far too long, sorry).
>
> xen/cpuid.h is an external header imported from Xen itself so in
> general I'd prefer to avoid modifying it unless we also send the
> changes upstream.
*sigh* Fool me once...
Can we shove it into arch/x86/include/asm/xen/hypervisor.h? Or is including
that in KVM too confusing/ugly?
next prev parent reply other threads:[~2023-01-04 20:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-20 13:40 [PATCH v6 0/2] KVM: x86/xen: update Xen CPUID Leaf 4 Paul Durrant
2022-12-20 13:40 ` [PATCH v6 1/2] KVM: x86/cpuid: generalize kvm_update_kvm_cpuid_base() and also capture limit Paul Durrant
2023-01-03 16:20 ` David Woodhouse
2023-01-04 19:34 ` Sean Christopherson
2023-01-05 10:38 ` Paul Durrant
2023-01-05 18:09 ` Sean Christopherson
2023-01-06 9:20 ` Paul Durrant
2022-12-20 13:40 ` [PATCH v6 2/2] KVM: x86/xen: update Xen CPUID Leaf 4 (tsc info) sub-leaves, if present Paul Durrant
2023-01-03 16:20 ` David Woodhouse
2023-01-04 19:40 ` Sean Christopherson
2023-01-04 20:09 ` David Woodhouse
2023-01-04 20:20 ` Sean Christopherson [this message]
2023-01-04 21:03 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y7Xfp3Izlc6VPEzC@google.com \
--to=seanjc@google.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=dwmw2@infradead.org \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=pdurrant@amazon.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox