From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43288C4708D for ; Wed, 4 Jan 2023 20:21:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240197AbjADUVI (ORCPT ); Wed, 4 Jan 2023 15:21:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37266 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240099AbjADUVA (ORCPT ); Wed, 4 Jan 2023 15:21:00 -0500 Received: from mail-pj1-x102c.google.com (mail-pj1-x102c.google.com [IPv6:2607:f8b0:4864:20::102c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 016C01A39A for ; Wed, 4 Jan 2023 12:21:00 -0800 (PST) Received: by mail-pj1-x102c.google.com with SMTP id cp9-20020a17090afb8900b00226a934e0e5so1779871pjb.1 for ; Wed, 04 Jan 2023 12:20:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=ueNCUU1joH9euY/HbmmGVwjQyc0PYYIVO96OTHvE0ao=; b=mCq6iUj955VpBOpUETCMOCmcUi1ndMguPbyRF6qZ0v5PbnVVMV+07vADKpC6zvPVAb YXLF7NzAyLstD/k14xDceObNSrKJ0Ju/HAzJI3oIA64Kl0TYO38dHAVGipD+tf2UuNX8 VimsU88ok764ibdxxjRj4kV4NjzhJKx8IIFLwBvXc3XhcrXfJK1/O/MEA0cV97KqKge0 G3ai6QlpSNioH+CVCiFtiyv9JnBi8lOfhxrsCf8qLEw1NPag4WQhHAQE2SvWU4HGfKCK ZxVU3LYJigf8w8KFzm4ySCVUMkK+N4Soqg3OMUqXrf2zs+4Ow2szCLiIsf7a5TY+lRGN ubMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ueNCUU1joH9euY/HbmmGVwjQyc0PYYIVO96OTHvE0ao=; b=0uXp86t3Tu8fdscqtPfzArzvuTjywKKdvACu/5xdY9mU5xqQiHqEwnBbqHdUtui5C9 GyPOfjbzQf3X8B54xxvo42+loASyZH7fVx8pGKd1jZVs2XflPlbzNvvz6S+dqSz5Nhpj 3CgU3xGmKLhN454TxgYBSRuRSEe0ww+vKfZX9q3YKf/m9rozGoF8jLsAA2m4A88KdXH3 nsrCtlIDL3sBi/CAbzMwpKuEhDI3RX8aB/ZUahrek1LMwFXiapFOiGrs1wb6h4qOwRvt wZHZh2Rw3UzmPGeFvaHccY87+r9VkbqMCsMVWMp2/4kdtspYh+FMQ16HQdSaUKP/Uzp7 gsCw== X-Gm-Message-State: AFqh2krUwp9IcD42F4wty9IS3WCvs1zyJ2oX0gwl/4ninAndWVuzCz3A /jFXoJXOTLZfUH7iJDAG7uaCqA== X-Google-Smtp-Source: AMrXdXvfBIZC9DvEaP53sNu9pwqkiHq9ym1mhOPVLfxa1brwpGlZtnRItERHkla0EY6ySKVDU1XVKw== X-Received: by 2002:a05:6a20:3b25:b0:b4:1a54:25c6 with SMTP id c37-20020a056a203b2500b000b41a5425c6mr1548126pzh.1.1672863659413; Wed, 04 Jan 2023 12:20:59 -0800 (PST) Received: from google.com (7.104.168.34.bc.googleusercontent.com. [34.168.104.7]) by smtp.gmail.com with ESMTPSA id s6-20020a170902ea0600b001913c5fc051sm24720394plg.274.2023.01.04.12.20.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Jan 2023 12:20:58 -0800 (PST) Date: Wed, 4 Jan 2023 20:20:55 +0000 From: Sean Christopherson To: David Woodhouse Cc: Paul Durrant , x86@kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" Subject: Re: [PATCH v6 2/2] KVM: x86/xen: update Xen CPUID Leaf 4 (tsc info) sub-leaves, if present Message-ID: References: <20221220134053.15591-1-pdurrant@amazon.com> <20221220134053.15591-3-pdurrant@amazon.com> <0e58d9a6bc8bf15c23feff25ec24e9b3c26945cc.camel@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <0e58d9a6bc8bf15c23feff25ec24e9b3c26945cc.camel@infradead.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 04, 2023, David Woodhouse wrote: > On Wed, 2023-01-04 at 19:40 +0000, Sean Christopherson wrote: > > > > arch/x86/include/asm/xen/hypervisor.h also open codes the signature.  Rather than > > add a KVM-specific define, what about putting in xen/cpuid.h?  (I've had a version > > of this series sitting in my todo pile for far too long, sorry). > > xen/cpuid.h is an external header imported from Xen itself so in > general I'd prefer to avoid modifying it unless we also send the > changes upstream. *sigh* Fool me once... Can we shove it into arch/x86/include/asm/xen/hypervisor.h? Or is including that in KVM too confusing/ugly?