Re: [PATCH 0/4] Allwinner D1 video engine support

Hans Verkuil
2023-01-23T12:34:12Z

Hi Samuel,

What is the status of this series? It seems to be mostly OK, but I did see
a few comments suggesting improvements.

Does this series depend on your PPU work? That was not clear.

I do think there were enough small comments to warrant a v2, unless you disagree?

Regards,

Hans

On 31/12/2022 17:46, Samuel Holland wrote:
> This series finishes adding Cedrus support for Allwinner D1. I had
> tested the hardware and documented the compatible string a while back,
> but at the time I had a dummy SRAM section in the devicetree. Further
> testing shows that there is no switchable SRAM section -- there is no
> need for it, I was unable to guess the address, and the usual bits in
> the SRAM controller register have no effect on the video engine. So that
> needs to be made optional in the binding and driver.
>
> With that done, the node can be added to the devicetree.
>
>
> Samuel Holland (4):
> media: dt-bindings: cedrus: Allow power domain references
> media: dt-bindings: cedrus: Make allwinner,sram optional
> media: cedrus: Make SRAM section claiming optional
> riscv: dts: allwinner: d1: Add video engine node
>
> .../media/allwinner,sun4i-a10-video-engine.yaml | 4 +++-
> arch/riscv/boot/dts/allwinner/sunxi-d1s-t113.dtsi | 11 +++++++++++
> drivers/staging/media/sunxi/cedrus/cedrus_hw.c | 2 +-
> 3 files changed, 15 insertions(+), 2 deletions(-)
>