From: Lee Jones <lee@kernel.org>
To: Jesse Taube <mr.bossman075@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
lee.jones@linaro.org
Subject: Re: [PATCH v2] drivers/mfd: simple-mfd-i2c: Add generic compatible
Date: Thu, 5 Jan 2023 14:56:13 +0000 [thread overview]
Message-ID: <Y7blDaQ6cSYuuR7U@google.com> (raw)
In-Reply-To: <20221202113226.114465-1-Mr.Bossman075@gmail.com>
On Fri, 02 Dec 2022, Jesse Taube wrote:
> Some devices may want to use this driver without having a specific
> compatible string. Add a generic compatible string to allow this.
>
> Signed-off-by: Jesse Taube <Mr.Bossman075@gmail.com>
> ---
> drivers/mfd/simple-mfd-i2c.c | 1 +
> 1 file changed, 1 insertion(+)
Sounds like a good idea. I've changed the subject line a little (no
need to say 'drivers') and applied the patch, thanks.
> diff --git a/drivers/mfd/simple-mfd-i2c.c b/drivers/mfd/simple-mfd-i2c.c
> index f4c8fc3ee463..0bda0dd9276e 100644
> --- a/drivers/mfd/simple-mfd-i2c.c
> +++ b/drivers/mfd/simple-mfd-i2c.c
> @@ -73,6 +73,7 @@ static const struct simple_mfd_data silergy_sy7636a = {
> };
>
> static const struct of_device_id simple_mfd_i2c_of_match[] = {
> + { .compatible = "simple-mfd-i2c-generic" },
> { .compatible = "kontron,sl28cpld" },
> { .compatible = "silergy,sy7636a", .data = &silergy_sy7636a},
> {}
> --
> 2.38.1
>
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2023-01-05 14:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-02 11:32 [PATCH v2] drivers/mfd: simple-mfd-i2c: Add generic compatible Jesse Taube
2022-12-14 18:05 ` Jesse Taube
2022-12-23 12:17 ` Lee Jones
2023-01-05 14:56 ` Lee Jones [this message]
2023-01-19 17:51 ` Rob Herring
2023-01-19 20:54 ` Lee Jones
2023-01-19 21:32 ` Jesse Taube
2023-01-20 14:14 ` Rob Herring
2023-01-26 14:32 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y7blDaQ6cSYuuR7U@google.com \
--to=lee@kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mr.bossman075@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox