From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ABDD5C3DA7D for ; Thu, 5 Jan 2023 15:27:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232701AbjAEP1S (ORCPT ); Thu, 5 Jan 2023 10:27:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50728 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233945AbjAEP1L (ORCPT ); Thu, 5 Jan 2023 10:27:11 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7C4EC4D4AC; Thu, 5 Jan 2023 07:27:10 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E46C561AF5; Thu, 5 Jan 2023 15:27:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B099AC433F0; Thu, 5 Jan 2023 15:27:07 +0000 (UTC) Authentication-Results: smtp.kernel.org; dkim=pass (1024-bit key) header.d=zx2c4.com header.i=@zx2c4.com header.b="Ugw0EnCF" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1672932425; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TncrA/pvVkIw+A2zNeeOTJM85e+imkBWpd4PkQKxlYY=; b=Ugw0EnCFgVMi65ku0kaVTH1fPe3oUPvJwOyFqId4WhEiK6UdbDXkmitQM8GeCMaCvIh4J7 BSptIZAYhkdMfbgpxDRNuNRptnLBu8JOFv8jxwM8qi0zzeIy/6hilEZnnYGqr5aCpB1MNs vRtDqX33rFPxXXtoESocKBpI4rvYtJQ= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id d8131bf6 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Thu, 5 Jan 2023 15:27:05 +0000 (UTC) Date: Thu, 5 Jan 2023 16:27:02 +0100 From: "Jason A. Donenfeld" To: James Bottomley Cc: Thorsten Leemhuis , Vlastimil Babka , Peter Huewe , Jarkko Sakkinen , Jason Gunthorpe , Jan Dabros , regressions@lists.linux.dev, LKML , linux-integrity@vger.kernel.org, Dominik Brodowski , Herbert Xu , Linus Torvalds , Johannes Altmanninger Subject: Re: [REGRESSION] suspend to ram fails in 6.2-rc1 due to tpm errors Message-ID: References: <7cbe96cf-e0b5-ba63-d1b4-f63d2e826efa@suse.cz> <7ebab1ff-48f1-2737-f0d3-25c72666d041@leemhuis.info> <2d07d185384ed444bef46648316354ef5afd481a.camel@HansenPartnership.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2d07d185384ed444bef46648316354ef5afd481a.camel@HansenPartnership.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 05, 2023 at 10:17:57AM -0500, James Bottomley wrote: > On Thu, 2023-01-05 at 14:59 +0100, Thorsten Leemhuis wrote: > > On 29.12.22 05:03, Jason A. Donenfeld wrote: > > > On Wed, Dec 28, 2022 at 06:07:25PM -0500, James Bottomley wrote: > > > > On Wed, 2022-12-28 at 21:22 +0100, Vlastimil Babka wrote: > > > > > Ugh, while the problem [1] was fixed in 6.1, it's now happening > > > > > again on the T460 with 6.2-rc1. Except I didn't see any oops > > > > > message or "tpm_try_transmit" error this time. The first > > > > > indication of a problem is this during a resume from suspend to > > > > > ram: > > > > > > > > > > tpm tpm0: A TPM error (28) occurred continue selftest > > > > > > > > > > and then periodically > > > > > > > > > > tpm tpm0: A TPM error (28) occurred attempting get random > > > > > > > > That's a TPM 1.2 error which means the TPM failed the selftest.  > > > > The original problem was reported against TPM 2.0  because of a > > > > missing try_get_ops(). > > > > > > No, I'm pretty sure the original bug, which was fixed by "char: > > > tpm: Protect tpm_pm_suspend with locks" regards 1.2 as well, > > > especially considering it's the same hardware from Vlastimil > > > causing this. I also recall seeing this in 1.2 when I ran this with > > > the TPM emulator. So that's not correct. > > > > James, are you or some other TPM developer looking into this? Or is > > this deadlocked now? > > Not really: TPM 1.2 way predates my interest in the TPM subsystem, and > I've only ever done patches to 2.0. I can look at the paths > theoretically, but I don't have any hardware. Self Test failures tend > to be hardware specific, so even poking around in the emulator is > unlikely to give what might be the cause. > > > And if so: how can we get this unstuck to get this regression > > solved? > > One of the TPM maintainers with hardware (possibly the specific TPM ... > what is it, by the way?) needs to get involved. I already wrote in my last email [1] that this simply isn't the case. The issue reproduces in QEMU + the emulator. It's far more likely to be a locking/race situation [2] than some kind of obscure hardware bug. Jason [1] https://lore.kernel.org/lkml/Y60RoP77HnwaukEA@zx2c4.com/ [2] https://lore.kernel.org/lkml/Y60Uu8HcGyXasnOO@zx2c4.com/