From: Chen Yu <yu.c.chen@intel.com>
To: 张元瀚 <zyhtheonly@gmail.com>
Cc: <mingo@redhat.com>, <peterz@infradead.org>,
<juri.lelli@redhat.com>, <vincent.guittot@linaro.org>,
<linux-kernel@vger.kernel.org>, <pmladek@suse.com>,
<zyhtheonly@yeah.net>, <zwp10758@gmail.com>
Subject: Re: [PATCH] sched: print parent comm in sched_show_task()
Date: Fri, 6 Jan 2023 17:51:55 +0800 [thread overview]
Message-ID: <Y7fvOz9jZPndTDqp@chenyu5-mobl1> (raw)
In-Reply-To: <CAEQmJ=gcCx1hMf7HicE5OFeUstipdtr=3JkF1JxLuP-CrG++Pw@mail.gmail.com>
Hi Tio,
On 2023-01-04 at 01:51:30 +0800, 张元瀚 wrote:
> Hi Chen,
> Thanks for your advice!
>
> > Maybe struct task_struct *parent = rcu_dereference(p->real_parent);
> > and use parent directly to get its pid and comm?
>
> Yes! It is good to write this way.
>
> > Maybe off-topic, what if the parent is a kernel thread/worker? It might
> have extra
> > name information such as kthread->full_name or worker->desc according to
> proc_task_name().
>
> I'm not quite sure if it is necessary to fetch that extra information since
> our sched_show_task() prints p->comm ourselves.
> But, assuming we get the parent's name in the same way we get
> proc_task_name(), there are some new issues I'd like to discuss.
> For example, if we write like this:
Petr suggested to keep it simple in another thread, so I think we do not
need to let extra information involve in for now.
thanks,
Chenyu
next prev parent reply other threads:[~2023-01-06 9:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-27 16:14 [PATCH] sched: print parent comm in sched_show_task() Tio Zhang
2022-12-29 4:25 ` Chen Yu
[not found] ` <CAEQmJ=gcCx1hMf7HicE5OFeUstipdtr=3JkF1JxLuP-CrG++Pw@mail.gmail.com>
2023-01-04 13:40 ` Petr Mladek
2023-01-06 9:51 ` Chen Yu [this message]
[not found] ` <CAEQmJ=gZJL6K1yUPq0hHy5D7Rc6g=5Ri72V_kE=xfqR6gJedWg@mail.gmail.com>
2023-01-12 8:40 ` Chen Yu
2023-01-04 13:24 ` Petr Mladek
-- strict thread matches above, loose matches on Subject: below --
2023-01-13 10:54 Tio Zhang
2023-01-16 9:26 ` Chen Yu
2023-01-17 8:33 ` 张元瀚 Tio Zhang
2023-01-18 11:06 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y7fvOz9jZPndTDqp@chenyu5-mobl1 \
--to=yu.c.chen@intel.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=vincent.guittot@linaro.org \
--cc=zwp10758@gmail.com \
--cc=zyhtheonly@gmail.com \
--cc=zyhtheonly@yeah.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox