From: "Gustavo A. R. Silva" <gustavoars@kernel.org>
To: Kees Cook <keescook@chromium.org>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
Dan Williams <dan.j.williams@intel.com>,
kernel test robot <lkp@intel.com>,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH] scsi: uapi: Replace 0-length array with flexible array
Date: Fri, 6 Jan 2023 10:17:39 -0600 [thread overview]
Message-ID: <Y7hJo5+TXOdCEXbB@work> (raw)
In-Reply-To: <20230105233042.never.913-kees@kernel.org>
On Thu, Jan 05, 2023 at 03:30:46PM -0800, Kees Cook wrote:
> Zero-length arrays are deprecated[1]. Replace struct
> fc_bsg_host_vendor_reply's "vendor_rsp" 0-length array with a flexible
> array. Detected with GCC 13, using -fstrict-flex-arrays=3:
>
> drivers/scsi/qla2xxx/qla_isr.c: In function 'qla25xx_process_bidir_status_iocb.isra':
> drivers/scsi/qla2xxx/qla_isr.c:3117:54: warning: array subscript 0 is outside array bounds of '__u32[0]' {aka 'unsigned int[]'} [-Warray-bounds=]
> 3117 | bsg_reply->reply_data.vendor_reply.vendor_rsp[0] = rval;
> | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~
> In file included from drivers/scsi/qla2xxx/qla_def.h:34,
> from drivers/scsi/qla2xxx/qla_isr.c:6:
> include/uapi/scsi/scsi_bsg_fc.h:219:15: note: while referencing 'vendor_rsp'
> 219 | __u32 vendor_rsp[0];
> | ^~~~~~~~~~
>
> [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays
>
> Cc: Martin K. Petersen <martin.petersen@oracle.com>
> Cc: Dan Williams <dan.j.williams@intel.com>
> Cc: "Gustavo A. R. Silva" <gustavoars@kernel.org>
> Signed-off-by: Kees Cook <keescook@chromium.org>
Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Thanks!
--
Gustavo
> ---
> include/uapi/scsi/scsi_bsg_fc.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/uapi/scsi/scsi_bsg_fc.h b/include/uapi/scsi/scsi_bsg_fc.h
> index 7f5930801f72..5e46cf1054af 100644
> --- a/include/uapi/scsi/scsi_bsg_fc.h
> +++ b/include/uapi/scsi/scsi_bsg_fc.h
> @@ -216,7 +216,7 @@ struct fc_bsg_host_vendor {
> */
> struct fc_bsg_host_vendor_reply {
> /* start of vendor response area */
> - __u32 vendor_rsp[0];
> + __DECLARE_FLEX_ARRAY(__u32, vendor_rsp);
> };
>
>
> --
> 2.34.1
>
next prev parent reply other threads:[~2023-01-06 16:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-05 23:30 [PATCH] scsi: uapi: Replace 0-length array with flexible array Kees Cook
2023-01-06 16:17 ` Gustavo A. R. Silva [this message]
2023-01-14 1:26 ` Martin K. Petersen
2023-01-19 0:23 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y7hJo5+TXOdCEXbB@work \
--to=gustavoars@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=keescook@chromium.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox